NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit7700597

committed

In pg_dump, show server and pg_dump versions with or without --verbose.

We used to print this information only in verbose mode, but it's arguedthat it's useful enough to print always; one reason being that thisprovides some documentation about which Postgres versions the dump ismeant to reload into.Jing Wang, reviewed by Jeevan Chalke

1 parent3088cc3 commit7700597Copy full SHA for 7700597

File tree

1 file changed

-8

lines changed

src/bin/pg_dump
- pg_backup_archiver.c

1 file changed

-8

lines changed

`‎src/bin/pg_dump/pg_backup_archiver.c`

Lines changed: 9 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -353,16 +353,17 @@ RestoreArchive(Archive *AHX)`
`353`	`353`
`354`	`354`	`ahprintf(AH,"--\n-- PostgreSQL database dump\n--\n\n");`
`355`	`355`
	`356`	`+if (AH->archiveRemoteVersion)`
	`357`	`+ahprintf(AH,"-- Dumped from database version %s\n",`
	`358`	`+AH->archiveRemoteVersion);`
	`359`	`+if (AH->archiveDumpVersion)`
	`360`	`+ahprintf(AH,"-- Dumped by pg_dump version %s\n",`
	`361`	`+AH->archiveDumpVersion);`
	`362`	`+`
	`363`	`+ahprintf(AH,"\n");`
	`364`	`+`
`356`	`365`	`if (AH->public.verbose)`
`357`		`-{`
`358`		`-if (AH->archiveRemoteVersion)`
`359`		`-ahprintf(AH,"-- Dumped from database version %s\n",`
`360`		`-AH->archiveRemoteVersion);`
`361`		`-if (AH->archiveDumpVersion)`
`362`		`-ahprintf(AH,"-- Dumped by pg_dump version %s\n",`
`363`		`-AH->archiveDumpVersion);`
`364`	`366`	`dumpTimestamp(AH,"Started on",AH->createDate);`
`365`		`-}`
`366`	`367`
`367`	`368`	`if (ropt->single_txn)`
`368`	`369`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7700597

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_backup_archiver.c`

0 commit comments