NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit766f7fd

committed

Add "break"s to make it clearer what will happen in a nested switch.

This could only matter if the guessed_type variable had a value that wasn'ta member of the PasswordType enum; but just in case, let's be sure thatcontrol falls out to reach the elog(ERROR) at the end of the function.Per gripe from Coverity.

1 parent835cc11 commit766f7fdCopy full SHA for 766f7fd

File tree

1 file changed

-0

lines changed

src/backend/libpq
- crypt.c

1 file changed

-0

lines changed

`‎src/backend/libpq/crypt.c‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ encrypt_password(PasswordType target_type, const char *role,`
`162`	`162`	`casePASSWORD_TYPE_MD5:`
`163`	`163`	`returnpstrdup(password);`
`164`	`164`	`}`
	`165`	`+break;`
`165`	`166`
`166`	`167`	`casePASSWORD_TYPE_SCRAM:`
`167`	`168`	`switch (guessed_type)`
`@@ -178,6 +179,7 @@ encrypt_password(PasswordType target_type, const char *role,`
`178`	`179`	`casePASSWORD_TYPE_SCRAM:`
`179`	`180`	`returnpstrdup(password);`
`180`	`181`	`}`
	`182`	`+break;`
`181`	`183`	`}`
`182`	`184`
`183`	`185`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit766f7fd

File tree

1 file changed

1 file changed

`‎src/backend/libpq/crypt.c‎`

0 commit comments