NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit76074fc

committed

ProcedureCreate neglected to record dependencies on default expressions.

Thus, an object referenced in a default expression could be dropped whilethe function remained present. This was unaccountably missed in theoriginal patch to add default parameters for functions. Reported byPavel Stehule.

1 parentd56b3af commit76074fcCopy full SHA for 76074fc

File tree

1 file changed

-0

lines changed

src/backend/catalog
- pg_proc.c

1 file changed

-0

lines changed

`‎src/backend/catalog/pg_proc.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -599,6 +599,11 @@ ProcedureCreate(const char *procedureName,`
`599`	`599`	`recordDependencyOn(&myself,&referenced,DEPENDENCY_NORMAL);`
`600`	`600`	`}`
`601`	`601`
	`602`	`+/* dependency on parameter default expressions */`
	`603`	`+if (parameterDefaults)`
	`604`	`+recordDependencyOnExpr(&myself, (Node*)parameterDefaults,`
	`605`	`+NIL,DEPENDENCY_NORMAL);`
	`606`	`+`
`602`	`607`	`/* dependency on owner */`
`603`	`608`	`if (!is_update)`
`604`	`609`	`recordDependencyOnOwner(ProcedureRelationId,retval,proowner);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit76074fc

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_proc.c`

0 commit comments