NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit74a379b

committed

Use repalloc_huge() to enlarge a SPITupleTable's tuple pointer array.

Commit23a27b0 widened the rows-stored counters to uint64, butthat's academic unless we allow the tuple pointer array to exceed 1GB.(It might be a good idea to provide some other limit on how much storagea SPITupleTable can eat. On the other hand, there are plenty of otherways to drive a backend into swap hell.)Dagfinn Ilmari Mannsåker

1 parent3adf9ce commit74a379bCopy full SHA for 74a379b

File tree

1 file changed

-1

lines changed

src/backend/executor
- spi.c

1 file changed

-1

lines changed

`‎src/backend/executor/spi.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1800,7 +1800,7 @@ spi_printtup(TupleTableSlot slot, DestReceiver self)`
`1800`	`1800`	`/* Double the size of the pointer array */`
`1801`	`1801`	`tuptable->free=tuptable->alloced;`
`1802`	`1802`	`tuptable->alloced+=tuptable->free;`
`1803`		`-tuptable->vals= (HeapTuple*)repalloc(tuptable->vals,`
	`1803`	`+tuptable->vals= (HeapTuple*)repalloc_huge(tuptable->vals,`
`1804`	`1804`	`tuptable->alloced*sizeof(HeapTuple));`
`1805`	`1805`	`}`
`1806`	`1806`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit74a379b

File tree

1 file changed

1 file changed

`‎src/backend/executor/spi.c`

0 commit comments