NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit73a4b99

committed

Make CREATE/ALTER FUNCTION support NOT LEAKPROOF.

Because it isn't good to be able to turn things on, and not off again.

1 parentd845fd6 commit73a4b99Copy full SHA for 73a4b99

File tree

3 files changed

+35

-21

lines changed

doc/src/sgml/ref
- alter_function.sgml
- create_function.sgml
src/backend/parser
- gram.y

3 files changed

+35

-21

lines changed

`‎doc/src/sgml/ref/alter_function.sgml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ ALTER FUNCTION <replaceable>name</replaceable> ( [ [ <replaceable class="paramet`
`33`	`33`	`<phrase>where <replaceable class="PARAMETER">action</replaceable> is one of:</phrase>`
`34`	`34`
`35`	`35`	`CALLED ON NULL INPUT \| RETURNS NULL ON NULL INPUT \| STRICT`
`36`		`- IMMUTABLE \| STABLE \| VOLATILE \| LEAKPROOF`
	`36`	`+ IMMUTABLE \| STABLE \| VOLATILE \|[ NOT ]LEAKPROOF`
`37`	`37`	`[ EXTERNAL ] SECURITY INVOKER \| [ EXTERNAL ] SECURITY DEFINER`
`38`	`38`	`COST <replaceable class="parameter">execution_cost</replaceable>`
`39`	`39`	`ROWS <replaceable class="parameter">result_rows</replaceable>`

`‎doc/src/sgml/ref/create_function.sgml‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ CREATE [ OR REPLACE ] FUNCTION`
`26`	`26`	`\| RETURNS TABLE ( <replaceable class="parameter">column_name</replaceable> <replaceable class="parameter">column_type</replaceable> [, ...] ) ]`
`27`	`27`	`{ LANGUAGE <replaceable class="parameter">lang_name</replaceable>`
`28`	`28`	`\| WINDOW`
`29`		`- \| IMMUTABLE \| STABLE \| VOLATILE \| LEAKPROOF`
	`29`	`+ \| IMMUTABLE \| STABLE \| VOLATILE \|[ NOT ]LEAKPROOF`
`30`	`30`	`\| CALLED ON NULL INPUT \| RETURNS NULL ON NULL INPUT \| STRICT`
`31`	`31`	`\| [ EXTERNAL ] SECURITY INVOKER \| [ EXTERNAL ] SECURITY DEFINER`
`32`	`32`	`\| COST <replaceable class="parameter">execution_cost</replaceable>`

`‎src/backend/parser/gram.y‎`

Lines changed: 33 additions & 19 deletions

Original file line number	Diff line number	Diff line change
`@@ -370,7 +370,7 @@ static void processCASbits(int cas_bits, int location, const char *constrType,`
`370`	`370`
`371`	`371`	`%type<istmt>insert_rest`
`372`	`372`
`373`		`-%type<vsetstmt>set_restSetResetClause`
	`373`	`+%type<vsetstmt>set_restset_rest_moreSetResetClauseFunctionSetResetClause`
`374`	`374`
`375`	`375`	`%type<node>TableElementTypedTableElementConstraintElemTableFuncElement`
`376`	`376`	`ForeignTableElement`
`@@ -1227,7 +1227,27 @@ VariableSetStmt:`
`1227`	`1227`	`}`
`1228`	`1228`	`;`
`1229`	`1229`
`1230`		`-set_rest:/* Generic SET syntaxes:*/`
	`1230`	`+set_rest:`
	`1231`	`+TRANSACTIONtransaction_mode_list`
	`1232`	`+{`
	`1233`	`+VariableSetStmt *n = makeNode(VariableSetStmt);`
	`1234`	`+n->kind = VAR_SET_MULTI;`
	`1235`	`+n->name ="TRANSACTION";`
	`1236`	`+n->args =$2;`
	`1237`	`+$$ = n;`
	`1238`	`+}`
	`1239`	`+\|SESSIONCHARACTERISTICSASTRANSACTIONtransaction_mode_list`
	`1240`	`+{`
	`1241`	`+VariableSetStmt *n = makeNode(VariableSetStmt);`
	`1242`	`+n->kind = VAR_SET_MULTI;`
	`1243`	`+n->name ="SESSION CHARACTERISTICS";`
	`1244`	`+n->args =$5;`
	`1245`	`+$$ = n;`
	`1246`	`+}`
	`1247`	`+\|set_rest_more`
	`1248`	`+;`
	`1249`	`+`
	`1250`	`+set_rest_more:/* Generic SET syntaxes:*/`
`1231`	`1251`	`var_nameTOvar_list`
`1232`	`1252`	`{`
`1233`	`1253`	`VariableSetStmt *n = makeNode(VariableSetStmt);`
`@@ -1277,22 +1297,6 @@ set_rest:/* Generic SET syntaxes: */`
`1277`	`1297`	`n->kind = VAR_SET_DEFAULT;`
`1278`	`1298`	`$$ = n;`
`1279`	`1299`	`}`
`1280`		`-\|TRANSACTIONtransaction_mode_list`
`1281`		`-{`
`1282`		`-VariableSetStmt *n = makeNode(VariableSetStmt);`
`1283`		`-n->kind = VAR_SET_MULTI;`
`1284`		`-n->name ="TRANSACTION";`
`1285`		`-n->args =$2;`
`1286`		`-$$ = n;`
`1287`		`-}`
`1288`		`-\|SESSIONCHARACTERISTICSASTRANSACTIONtransaction_mode_list`
`1289`		`-{`
`1290`		`-VariableSetStmt *n = makeNode(VariableSetStmt);`
`1291`		`-n->kind = VAR_SET_MULTI;`
`1292`		`-n->name ="SESSION CHARACTERISTICS";`
`1293`		`-n->args =$5;`
`1294`		`-$$ = n;`
`1295`		`-}`
`1296`	`1300`	`\|CATALOG_PSconst`
`1297`	`1301`	`{`
`1298`	`1302`	`ereport(ERROR,`
`@@ -1512,6 +1516,12 @@ SetResetClause:`
`1512`	`1516`	`\|VariableResetStmt{$$ = (VariableSetStmt *)$1; }`
`1513`	`1517`	`;`
`1514`	`1518`
	`1519`	`+/* SetResetClause allows SET or RESET without LOCAL*/`
	`1520`	`+FunctionSetResetClause:`
	`1521`	`+SETset_rest_more{$$ =$2; }`
	`1522`	`+\|VariableResetStmt{$$ = (VariableSetStmt *)$1; }`
	`1523`	`+;`
	`1524`	`+`
`1515`	`1525`
`1516`	`1526`	`VariableShowStmt:`
`1517`	`1527`	`SHOWvar_name`
`@@ -6119,6 +6129,10 @@ common_func_opt_item:`
`6119`	`6129`	`{`
`6120`	`6130`	`$$ = makeDefElem("leakproof", (Node *)makeInteger(TRUE));`
`6121`	`6131`	`}`
	`6132`	`+\|NOTLEAKPROOF`
	`6133`	`+{`
	`6134`	`+$$ = makeDefElem("leakproof", (Node *)makeInteger(FALSE));`
	`6135`	`+}`
`6122`	`6136`	`\|COSTNumericOnly`
`6123`	`6137`	`{`
`6124`	`6138`	`$$ = makeDefElem("cost", (Node *)$2);`
`@@ -6127,7 +6141,7 @@ common_func_opt_item:`
`6127`	`6141`	`{`
`6128`	`6142`	`$$ = makeDefElem("rows", (Node *)$2);`
`6129`	`6143`	`}`
`6130`		`-\|SetResetClause`
	`6144`	`+\|FunctionSetResetClause`
`6131`	`6145`	`{`
`6132`	`6146`	`/* we abuse the normal content of a DefElem here*/`
`6133`	`6147`	`$$ = makeDefElem("set", (Node *)$1);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit73a4b99

File tree

3 files changed

3 files changed

`‎doc/src/sgml/ref/alter_function.sgml‎`

`‎doc/src/sgml/ref/create_function.sgml‎`

`‎src/backend/parser/gram.y‎`

0 commit comments