NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit737cdc2

committed

Fix bogus return macros in range_overright_internal().

PG_RETURN_BOOL() should only be used in functions following the V1 SQLfunction API. This coding accidentally fails to fail since letting thecompiler coerce the Datum representation of bool back to plain booldoes give the right answer; but that doesn't make it a good idea.Back-patch to older branches just to avoid unnecessary code divergence.

1 parenta068b5b commit737cdc2Copy full SHA for 737cdc2

File tree

1 file changed

-3

lines changed

src/backend/utils/adt
- rangetypes.c

1 file changed

-3

lines changed

`‎src/backend/utils/adt/rangetypes.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -917,12 +917,12 @@ range_overright_internal(TypeCacheEntry typcache, RangeType r1, RangeType *r2)`
`917`	`917`
`918`	`918`	`/* An empty range is neither before nor after any other range */`
`919`	`919`	`if (empty1\|\|empty2)`
`920`		`-PG_RETURN_BOOL(false);`
	`920`	`+returnfalse;`
`921`	`921`
`922`	`922`	`if (range_cmp_bounds(typcache,&lower1,&lower2) >=0)`
`923`		`-PG_RETURN_BOOL(true);`
	`923`	`+returntrue;`
`924`	`924`
`925`		`-PG_RETURN_BOOL(false);`
	`925`	`+returnfalse;`
`926`	`926`	`}`
`927`	`927`
`928`	`928`	`/* does not extend to left of? */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit737cdc2

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/rangetypes.c`

0 commit comments