Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7320681

Browse files
committed
Change SQLSTATE for event triggers "wrong context" message
When certain event-trigger-only functions are called when not in thewrong context, they were reporting the "feature not supported" SQLSTATE,which is somewhat misleading. Create a new custom error code for suchuses instead.Not backpatched since it may be seen as an undesirable behavioralchange.Author: Michael PaquierDiscussion:https://www.postgresql.org/message-id/CAB7nPqQ-5NAkHQHh_NOm7FPep37NCiLKwPoJ2Yxb8TDoGgbYYA@mail.gmail.com
1 parent5df64f2 commit7320681

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

‎src/backend/commands/event_trigger.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1416,7 +1416,7 @@ pg_event_trigger_dropped_objects(PG_FUNCTION_ARGS)
14161416
if (!currentEventTriggerState||
14171417
!currentEventTriggerState->in_sql_drop)
14181418
ereport(ERROR,
1419-
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
1419+
(errcode(ERRCODE_E_R_I_E_EVENT_TRIGGER_PROTOCOL_VIOLATED),
14201420
errmsg("%s can only be called in a sql_drop event trigger function",
14211421
"pg_event_trigger_dropped_objects()")));
14221422

@@ -1536,7 +1536,7 @@ pg_event_trigger_table_rewrite_oid(PG_FUNCTION_ARGS)
15361536
if (!currentEventTriggerState||
15371537
currentEventTriggerState->table_rewrite_oid==InvalidOid)
15381538
ereport(ERROR,
1539-
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
1539+
(errcode(ERRCODE_E_R_I_E_EVENT_TRIGGER_PROTOCOL_VIOLATED),
15401540
errmsg("%s can only be called in a table_rewrite event trigger function",
15411541
"pg_event_trigger_table_rewrite_oid()")));
15421542

@@ -1557,7 +1557,7 @@ pg_event_trigger_table_rewrite_reason(PG_FUNCTION_ARGS)
15571557
if (!currentEventTriggerState||
15581558
currentEventTriggerState->table_rewrite_reason==0)
15591559
ereport(ERROR,
1560-
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
1560+
(errcode(ERRCODE_E_R_I_E_EVENT_TRIGGER_PROTOCOL_VIOLATED),
15611561
errmsg("%s can only be called in a table_rewrite event trigger function",
15621562
"pg_event_trigger_table_rewrite_reason()")));
15631563

‎src/backend/utils/errcodes.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ Section: Class 39 - External Routine Invocation Exception
278278
39004 E ERRCODE_E_R_I_E_NULL_VALUE_NOT_ALLOWED null_value_not_allowed
279279
39P01 E ERRCODE_E_R_I_E_TRIGGER_PROTOCOL_VIOLATED trigger_protocol_violated
280280
39P02 E ERRCODE_E_R_I_E_SRF_PROTOCOL_VIOLATED srf_protocol_violated
281+
39P03 E ERRCODE_E_R_I_E_EVENT_TRIGGER_PROTOCOL_VIOLATED event_trigger_protocol_violated
281282

282283
Section: Class 3B - Savepoint Exception
283284

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp