Commit72e2db8

committed

Don't try to close negative file descriptors, since this can cause

crashes on certain platforms. In particular, the MSVC runtime is knownto do this.Fixes bug #4162, reported and diagnosed by Javier Pimas

1 parentd82a1d5 commit72e2db8Copy full SHA for 72e2db8

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.307 2008/05/12 19:45:23 mha Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.308 2008/05/13 20:53:52 mha Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -3334,8 +3334,11 @@ got_record:;`
`3334`	`3334`	`return (XLogRecord*)buffer;`
`3335`	`3335`
`3336`	`3336`	`next_record_is_invalid:;`
`3337`		`-close(readFile);`
`3338`		`-readFile=-1;`
	`3337`	`+if (readFile >=0)`
	`3338`	`+{`
	`3339`	`+close(readFile);`
	`3340`	`+readFile=-1;`
	`3341`	`+}`
`3339`	`3342`	`nextRecord=NULL;`
`3340`	`3343`	`returnNULL;`
`3341`	`3344`	`}`

Comments

(0)