NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit7250d85

committed

Fix building with WAL_DEBUG.

Now that the backup blocks are appended to the WAL record in xloginsert.c,XLogInsert doesn't see them anymore and cannot remove them from the versionreconstructed for xlog_outdesc. This makes running with wal_debug=on moreexpensive, as we now make (unnecessary) temporary copies of the backupblocks, but it doesn't seem worth convoluting the code to keep thatoptimization.Reported by Alvaro Herrera.

1 parent5ea86e6 commit7250d85Copy full SHA for 7250d85

File tree

1 file changed

-4

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-4

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1067,11 +1067,8 @@ XLogInsertRecord(XLogRecData *rdata, XLogRecPtr fpw_lsn)`
`1067`	`1067`	`/*`
`1068`	`1068`	`* We have to piece together the WAL record data from the`
`1069`	`1069`	`* XLogRecData entries, so that we can pass it to the rm_desc`
`1070`		`- * function as one contiguous chunk. (but we can leave out any`
`1071`		`- * extra entries we created for backup blocks)`
	`1070`	`+ * function as one contiguous chunk.`
`1072`	`1071`	`*/`
`1073`		`-rdt_lastnormal->next=NULL;`
`1074`		`-`
`1075`	`1072`	`initStringInfo(&recordbuf);`
`1076`	`1073`	`appendBinaryStringInfo(&recordbuf, (char*)rechdr,sizeof(XLogRecord));`
`1077`	`1074`	`for (;rdata!=NULL;rdata=rdata->next)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7250d85

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments