NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit70868c0

committed

Increase the initial size of StringInfo buffers to 1024 bytes (from 256);

likewise increase the initial size of the scanner's literal buffer to 1024(from 128). Instrumentation of the regression tests suggests that thissaves a useful amount of repalloc() traffic --- the number of calls occurringduring one set of tests drops from about 6900 to about 3900. The old sizeswere chosen in the late 90's with an eye to machines much smaller thanare common today.

1 parentae65ca3 commit70868c0Copy full SHA for 70868c0

File tree

2 files changed

-4

lines changed

src/backend
- lib
  - stringinfo.c
- parser
  - scan.l

2 files changed

-4

lines changed

`‎src/backend/lib/stringinfo.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`* Portions Copyright (c) 1996-2007, PostgreSQL Global Development Group`
`10`	`10`	`* Portions Copyright (c) 1994, Regents of the University of California`
`11`	`11`	`*`
`12`		`- * $PostgreSQL: pgsql/src/backend/lib/stringinfo.c,v 1.46 2007/05/28 16:43:24 tgl Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/lib/stringinfo.c,v 1.47 2007/08/12 20:18:06 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -45,7 +45,7 @@ makeStringInfo(void)`
`45`	`45`	`void`
`46`	`46`	`initStringInfo(StringInfostr)`
`47`	`47`	`{`
`48`		`-intsize=256;/* initial default buffer size */`
	`48`	`+intsize=1024;/* initial default buffer size */`
`49`	`49`
`50`	`50`	`str->data= (char*)palloc(size);`
`51`	`51`	`str->maxlen=size;`

`‎src/backend/parser/scan.l`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`* Portions Copyright (c) 1994, Regents of the University of California`
`25`	`25`	`*`
`26`	`26`	`* IDENTIFICATION`
`27`		`- * $PostgreSQL: pgsql/src/backend/parser/scan.l,v 1.139 2007/01/05 22:19:34 momjian Exp $`
	`27`	`+ * $PostgreSQL: pgsql/src/backend/parser/scan.l,v 1.140 2007/08/12 20:18:06 tgl Exp $`
`28`	`28`	`*`
`29`	`29`	`*-------------------------------------------------------------------------`
`30`	`30`	`*/`
`@@ -820,7 +820,7 @@ scanner_init(const char *str)`
`820`	`820`	`scanbufhandle =yy_scan_buffer(scanbuf, slen +2);`
`821`	`821`
`822`	`822`	`/* initialize literal buffer to a reasonable but expansible size */`
`823`		`-literalalloc =128;`
	`823`	`+literalalloc =1024;`
`824`	`824`	`literalbuf = (char *)palloc(literalalloc);`
`825`	`825`	`startlit();`
`826`	`826`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit70868c0

File tree

2 files changed

2 files changed

`‎src/backend/lib/stringinfo.c`

`‎src/backend/parser/scan.l`

0 commit comments