Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6ba8af9

Browse files
committed
Remove restriction that cast functions cannot be volatile. This
restriction was debatable to begin with, but it has now become obviousthat it breaks forward-porting of user-defined types; contrib/lo beingthe most salient example.
1 parente0a1ee2 commit6ba8af9

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

‎doc/src/sgml/ref/create_cast.sgml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- $Header: /cvsroot/pgsql/doc/src/sgml/ref/create_cast.sgml,v 1.8 2003/01/19 00:13:29 momjian Exp $ -->
1+
<!-- $Header: /cvsroot/pgsql/doc/src/sgml/ref/create_cast.sgml,v 1.9 2003/02/01 22:09:25 tgl Exp $ -->
22

33
<refentry id="SQL-CREATECAST">
44
<refmeta>
@@ -143,7 +143,7 @@ SELECT 'The time is ' || CAST(now() AS text);
143143
be schema-qualified. If it is not, the function will be looked
144144
up in the path. The argument type must be identical to the
145145
source type, the result data type must match the target type of
146-
the cast. Cast functions must be marked immutable or stable.
146+
the cast.
147147
</para>
148148
</listitem>
149149
</varlistentry>

‎src/backend/commands/functioncmds.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
*
1010
*
1111
* IDENTIFICATION
12-
* $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.24 2002/11/0119:19:58 tgl Exp $
12+
* $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.25 2003/02/0122:09:26 tgl Exp $
1313
*
1414
* DESCRIPTION
1515
* These routines take the parse tree and pick out the
@@ -745,8 +745,15 @@ CreateCast(CreateCastStmt *stmt)
745745
elog(ERROR,"argument of cast function must match source data type");
746746
if (procstruct->prorettype!=targettypeid)
747747
elog(ERROR,"return data type of cast function must match target data type");
748+
/*
749+
* Restricting the volatility of a cast function may or may not be
750+
* a good idea in the abstract, but it definitely breaks many old
751+
* user-defined types. Disable this check --- tgl 2/1/03
752+
*/
753+
#ifdefNOT_USED
748754
if (procstruct->provolatile==PROVOLATILE_VOLATILE)
749755
elog(ERROR,"cast function must not be volatile");
756+
#endif
750757
if (procstruct->proisagg)
751758
elog(ERROR,"cast function must not be an aggregate function");
752759
if (procstruct->proretset)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp