NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit6b3b3a5

committed

Remove dead code in pg_dump.

Coverity quite reasonably complained that this check for fout==NULLoccurred after we'd already dereferenced fout. However, the checkis just dead code since there is no code path by which CreateArchivecan return a null pointer. Errors such as can't-open-that-file arereported down inside CreateArchive, and control doesn't return.So let's silence the warning by removing the dead code, rather thancontinuing to pretend it does something.Coverity didn't complain about this before5b5fea2, so back-patchto 9.5 like that patch.

1 parent0760225 commit6b3b3a5Copy full SHA for 6b3b3a5

File tree

1 file changed

-3

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-3

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -611,9 +611,6 @@ main(int argc, char **argv)`
`611`	`611`	`/* Register the cleanup hook */`
`612`	`612`	`on_exit_close_archive(fout);`
`613`	`613`
`614`		`-if (fout==NULL)`
`615`		`-exit_horribly(NULL,"could not open output file \"%s\" for writing\n",filename);`
`616`		`-`
`617`	`614`	`/* Let the archiver know how noisy to be */`
`618`	`615`	`fout->verbose=g_verbose;`
`619`	`616`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6b3b3a5

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments