NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit6aa2e49

committed

Must not reach consistency before XLOG_BACKUP_RECORD

When waiting for an XLOG_BACKUP_RECORD the minRecoveryPointwill be incorrect, so we must not declare recovery as consistentbefore we have seen the record. Major bug allowing recovery to endtoo early in some cases, allowing people to see inconsistent db.This patch to HEAD and 9.2, other fix required for 9.1 and 9.0Simon Riggs and Andres Freund, bug report by Jeff Janes

1 parent357cbaa commit6aa2e49Copy full SHA for 6aa2e49

File tree

1 file changed

-2

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-2

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6332,9 +6332,12 @@ CheckRecoveryConsistency(void)`
`6332`	`6332`	`return;`
`6333`	`6333`
`6334`	`6334`	`/*`
`6335`		`- * Have we passed our safe starting point?`
	`6335`	`+ * Have we passed our safe starting point? Note that minRecoveryPoint`
	`6336`	`+ * is known to be incorrectly set if ControlFile->backupEndRequired,`
	`6337`	`+ * until the XLOG_BACKUP_RECORD arrives to advise us of the correct`
	`6338`	`+ * minRecoveryPoint. All we prior to that is its not consistent yet.`
`6336`	`6339`	`*/`
`6337`		`-if (!reachedConsistency&&`
	`6340`	`+if (!reachedConsistency&& !ControlFile->backupEndRequired&&`
`6338`	`6341`	`XLByteLE(minRecoveryPoint,EndRecPtr)&&`
`6339`	`6342`	`XLogRecPtrIsInvalid(ControlFile->backupStartPoint))`
`6340`	`6343`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6aa2e49

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments