NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit683abc7

committed

Ignore invalid indexes in pg_dump.

Dumping invalid indexes can cause problems at restore time, for exampleif the reason the index creation failed was because it tried to enforcea uniqueness condition not satisfied by the table's data. Also, if theindex creation is in fact still in progress, it seems reasonable toconsider it to be an uncommitted DDL change, which pg_dump wouldn't beexpected to dump anyway.Back-patch to all active versions, and teach them to ignore invalidindexes in servers back to 8.2, where the concept was introduced.Michael Paquier

1 parent625b237 commit683abc7Copy full SHA for 683abc7

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4920,6 +4920,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables)`
`4920`	`4920`	`"i.indexrelid = c.conindid AND "`
`4921`	`4921`	`"c.contype IN ('p','u','x')) "`
`4922`	`4922`	`"WHERE i.indrelid = '%u'::pg_catalog.oid "`
	`4923`	`+"AND i.indisvalid "`
`4923`	`4924`	`"ORDER BY indexname",`
`4924`	`4925`	`tbinfo->dobj.catId.oid);`
`4925`	`4926`	`}`
`@@ -4949,6 +4950,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables)`
`4949`	`4950`	`"ON (d.refclassid = c.tableoid "`
`4950`	`4951`	`"AND d.refobjid = c.oid) "`
`4951`	`4952`	`"WHERE i.indrelid = '%u'::pg_catalog.oid "`
	`4953`	`+"AND i.indisvalid "`
`4952`	`4954`	`"ORDER BY indexname",`
`4953`	`4955`	`tbinfo->dobj.catId.oid);`
`4954`	`4956`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit683abc7

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments