NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit67eb3e5

committed

Avoid moving data directory in upgrade testing.

Windows sometimes gets upset if we rename a large directory and then tryto use the old name quickly, as seen in occasional buildfarm failures.So we avoid that by building the old version in the intendeddestination in the first place instead of renaming it, similar to thechange made for the same reason in commitb7f8465.

1 parentb015558 commit67eb3e5Copy full SHA for 67eb3e5

File tree

1 file changed

-3

lines changed

contrib/pg_upgrade
- test.sh

1 file changed

-3

lines changed

`‎contrib/pg_upgrade/test.sh`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -62,9 +62,10 @@ newsrc=`cd ../.. && pwd`
`62`	`62`	`PATH=$bindir:$PATH`
`63`	`63`	`export PATH`
`64`	`64`
`65`		`-PGDATA=$temp_root/data`
	`65`	`+BASE_PGDATA=$temp_root/data`
	`66`	`+PGDATA="$BASE_PGDATA.old"`
`66`	`67`	`export PGDATA`
`67`		`-rm -rf"$PGDATA""$PGDATA".old`
	`68`	`+rm -rf"$BASE_PGDATA""$PGDATA"`
`68`	`69`
`69`	`70`	`unset PGDATABASE`
`70`	`71`	`unset PGUSER`
`@@ -120,7 +121,7 @@ if [ -n "$pg_dumpall1_status" ]; then`
`120`	`121`	`exit 1`
`121`	`122`	`fi`
`122`	`123`
`123`		`-mv"${PGDATA}""${PGDATA}.old"`
	`124`	`+PGDATA=$BASE_PGDATA`
`124`	`125`
`125`	`126`	`initdb -N`
`126`	`127`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit67eb3e5

File tree

1 file changed

1 file changed

`‎contrib/pg_upgrade/test.sh`

0 commit comments