NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit660a081

committed

Fix handling of extension membership when filling in a shell operator.

The previous coding would result in deleting and not re-creating theextension membership pg_depend rows, since there was noCommandCounterIncrement that would allow recordDependencyOnCurrentExtensionto see that the deletion had happened. Make it work like the shell typecase, ie, keep the existing entries (and then throw an error if they're forthe wrong extension).Per bug #6172 from Hitoshi Harada. Investigation and fix by DimitriFontaine.

1 parent5473f28 commit660a081Copy full SHA for 660a081

File tree

1 file changed

-2

lines changed

src/backend/catalog
- pg_operator.c

1 file changed

-2

lines changed

`‎src/backend/catalog/pg_operator.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -774,8 +774,11 @@ makeOperatorDependencies(HeapTuple tuple)`
`774`	`774`	`myself.objectId=HeapTupleGetOid(tuple);`
`775`	`775`	`myself.objectSubId=0;`
`776`	`776`
`777`		`-/* In case we are updating a shell, delete any existing entries */`
`778`		`-deleteDependencyRecordsFor(myself.classId,myself.objectId, false);`
	`777`	`+/*`
	`778`	`+ * In case we are updating a shell, delete any existing entries, except`
	`779`	`+ * for extension membership which should remain the same.`
	`780`	`+ */`
	`781`	`+deleteDependencyRecordsFor(myself.classId,myself.objectId, true);`
`779`	`782`	`deleteSharedDependencyRecordsFor(myself.classId,myself.objectId,0);`
`780`	`783`
`781`	`784`	`/* Dependency on namespace */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit660a081

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_operator.c`

0 commit comments