@@ -435,35 +435,41 @@ sub upgradecheck
435
435
print " \n Running initdb on old cluster\n\n " ;
436
436
standard_initdb()or exit 1;
437
437
print " \n Starting old cluster\n\n " ;
438
- system (" pg_ctl start -l$logdir /postmaster1.log -w" ) == 0or exit 1;
438
+ my @args = (' pg_ctl' ,' start' ,' -l' ," $logdir /postmaster1.log" ,' -w' );
439
+ system (@args ) == 0or exit 1;
439
440
print " \n Setting up data for upgrading\n\n " ;
440
441
installcheck();
441
442
442
443
# now we can chdir into the source dir
443
444
chdir " $topdir /src/bin/pg_upgrade" ;
444
445
print " \n Dumping old cluster\n\n " ;
445
- system (" pg_dumpall -f$tmp_root /dump1.sql" ) == 0or exit 1;
446
+ @args = (' pg_dumpall' ,' -f' ," $tmp_root /dump1.sql" );
447
+ system (@args ) == 0or exit 1;
446
448
print " \n Stopping old cluster\n\n " ;
447
449
system (" pg_ctl -m fast stop" ) == 0or exit 1;
448
450
$ENV {PGDATA } =" $data " ;
449
451
print " \n Setting up new cluster\n\n " ;
450
452
standard_initdb()or exit 1;
451
453
print " \n Running pg_upgrade\n\n " ;
452
- system (" pg_upgrade -d$data .old -D$data -b$bindir -B$bindir " ) == 0
453
- or exit 1;
454
+ @args = (' pg_upgrade' ,' -d' ," $data .old" ,' -D' ,$data ,' -b' ,$bindir ,
455
+ ' -B' ,$bindir );
456
+ system (@args ) == 0or exit 1;
454
457
print " \n Starting new cluster\n\n " ;
455
- system (" pg_ctl -l$logdir /postmaster2.log -w start" ) == 0or exit 1;
458
+ @args = (' pg_ctl' ,' -l' ," $logdir /postmaster2.log" ,' -w' ,' start' );
459
+ system (@args ) == 0or exit 1;
456
460
print " \n Setting up stats on new cluster\n\n " ;
457
461
system (" .\\ analyze_new_cluster.bat" ) == 0or exit 1;
458
462
print " \n Dumping new cluster\n\n " ;
459
- system (" pg_dumpall -f$tmp_root /dump2.sql" ) == 0or exit 1;
463
+ @args = (' pg_dumpall' ,' -f' ," $tmp_root /dump2.sql" );
464
+ system (@args ) == 0or exit 1;
460
465
print " \n Stopping new cluster\n\n " ;
461
466
system (" pg_ctl -m fast stop" ) == 0or exit 1;
462
467
print " \n Deleting old cluster\n\n " ;
463
468
system (" .\\ delete_old_cluster.bat" ) == 0or exit 1;
464
469
print " \n Comparing old and new cluster dumps\n\n " ;
465
470
466
- system (" diff -q$tmp_root /dump1.sql$tmp_root /dump2.sql" );
471
+ @args = (' diff' ,' -q' ," $tmp_root /dump1.sql" ," $tmp_root /dump2.sql" );
472
+ system (@args );
467
473
$status =$? ;
468
474
if (!$status )
469
475
{