Commit623cf5e

committed

Add a failure check for syslogger's use of _beginthreadex(), and remove

unnecessary thread address output parameter, to make this code look morelike that in pg_restore.

1 parentc242502 commit623cf5eCopy full SHA for 623cf5e

File tree

-6

lines changed

-6

lines changed

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`*`
`19`	`19`	`*`
`20`	`20`	`* IDENTIFICATION`
`21`		`- * $PostgreSQL: pgsql/src/backend/postmaster/syslogger.c,v 1.47 2009/01/01 17:23:46 momjian Exp $`
	`21`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/syslogger.c,v 1.48 2009/02/03 00:59:26 tgl Exp $`
`22`	`22`	`*`
`23`	`23`	`*-------------------------------------------------------------------------`
`24`	`24`	`*/`
`@@ -267,11 +267,9 @@ SysLoggerMain(int argc, char *argv[])`
`267`	`267`	`/* Fire up separate data transfer thread */`
`268`	`268`	`InitializeCriticalSection(&sysfileSection);`
`269`	`269`
`270`		`-{`
`271`		`-unsignedinttid;`
`272`		`-`
`273`		`-threadHandle= (HANDLE)_beginthreadex(0,0,pipeThread,0,0,&tid);`
`274`		`-}`
	`270`	`+threadHandle= (HANDLE)_beginthreadex(NULL,0,pipeThread,NULL,0,NULL);`
	`271`	`+if (threadHandle==0)`
	`272`	`+elog(FATAL,"could not create syslogger data transfer thread: %m");`
`275`	`273`	`#endif/* WIN32 */`
`276`	`274`
`277`	`275`	`/* remember active logfile parameters */`

Comments

(0)