NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit5f95521

committed

Fix unsafe use of strtol() on a non-null-terminated Text datum.

jsonb_set() could produce wrong answers or incorrect error reports, or inthe worst case even crash, when trying to convert a path-array element intoan integer for use as an array subscript. Per report from Vitaly Burovoy.Back-patch to 9.5 where the faulty code was introduced (in commitc694701).Michael Paquier

1 parent147112d commit5f95521Copy full SHA for 5f95521

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- jsonfuncs.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/jsonfuncs.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3873,7 +3873,7 @@ setPathArray(JsonbIterator *it, Datum path_elems, bool *path_nulls,`
`3873`	`3873`	`/* pick correct index */`
`3874`	`3874`	`if (level<path_len&& !path_nulls[level])`
`3875`	`3875`	`{`
`3876`		`-char*c=VARDATA_ANY(path_elems[level]);`
	`3876`	`+char*c=TextDatumGetCString(path_elems[level]);`
`3877`	`3877`	`longlindex;`
`3878`	`3878`
`3879`	`3879`	`errno=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5f95521

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/jsonfuncs.c`

0 commit comments