NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit5e8e794

committed

Focus on ftello result < 0 instead of errno

Rather than reset errno (or just hope that its cleared already),check just the result of the ftello for < 0 to determine if therewas an issue.Oversight by me, pointed out by Tom.

1 parent8198a32 commit5e8e794Copy full SHA for 5e8e794

File tree

1 file changed

-3

lines changed

src/bin/pg_dump
- pg_backup_custom.c

1 file changed

-3

lines changed

`‎src/bin/pg_dump/pg_backup_custom.c`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -708,7 +708,7 @@ _CloseArchive(ArchiveHandle *AH)`
`708`	`708`	`{`
`709`	`709`	`WriteHead(AH);`
`710`	`710`	`tpos=ftello(AH->FH);`
`711`		`-if (tpos<0\|\|errno)`
	`711`	`+if (tpos<0)`
`712`	`712`	`exit_horribly(modulename,"could not determine seek position in archive file: %s\n",`
`713`	`713`	`strerror(errno));`
`714`	`714`	`WriteToc(AH);`
`@@ -757,9 +757,8 @@ _ReopenArchive(ArchiveHandle *AH)`
`757`	`757`	`if (!ctx->hasSeek)`
`758`	`758`	`exit_horribly(modulename,"parallel restore from non-seekable file is not supported\n");`
`759`	`759`
`760`		`-errno=0;`
`761`	`760`	`tpos=ftello(AH->FH);`
`762`		`-if (tpos<0\|\|errno)`
	`761`	`+if (tpos<0)`
`763`	`762`	`exit_horribly(modulename,"could not determine seek position in archive file: %s\n",`
`764`	`763`	`strerror(errno));`
`765`	`764`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5e8e794

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_backup_custom.c`

0 commit comments