NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit5d1826f

committed

Fix wrong allocation size inc8f621c.

Inc8f621c I forgot to account for MAXALIGN when allocating a newtuplebuf in ReorderBufferGetTupleBuf(). That happens to currently notcause active problems on a number of platforms because the affectedpointer is already aligned, but others, like ppc and hppa, trigger thisin the regression test, due to a debug memset clearing memory.Fix that.Backpatch: 9.4, like the previous commit.

1 parentc2d61ad commit5d1826fCopy full SHA for 5d1826f

File tree

1 file changed

-1

lines changed

src/backend/replication/logical
- reorderbuffer.c

1 file changed

-1

lines changed

`‎src/backend/replication/logical/reorderbuffer.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,8 @@ ReorderBufferGetTupleBuf(ReorderBuffer *rb, Size tuple_len)`
`483`	`483`	`{`
`484`	`484`	`tuple= (ReorderBufferTupleBuf*)`
`485`	`485`	`MemoryContextAlloc(rb->context,`
`486`		`-sizeof(ReorderBufferTupleBuf)+alloc_len);`
	`486`	`+sizeof(ReorderBufferTupleBuf)+`
	`487`	`+MAXIMUM_ALIGNOF+alloc_len);`
`487`	`488`	`tuple->alloc_tuple_size=alloc_len;`
`488`	`489`	`tuple->tuple.t_data=ReorderBufferTupleBufData(tuple);`
`489`	`490`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d1826f

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/reorderbuffer.c‎`

0 commit comments