Commit5c2a7c6

committed

Add a comment explaining why we force physical removal of OIDs.

Noah Misch, slightly revised.

1 parenta06e41d commit5c2a7c6Copy full SHA for 5c2a7c6

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4942,7 +4942,9 @@ ATExecDropColumn(List *wqueue, Relation rel, const char colName,`
`4942`	`4942`
`4943`	`4943`	`/*`
`4944`	`4944`	`* If we dropped the OID column, must adjust pg_class.relhasoids and tell`
`4945`		`- * Phase 3 to physically get rid of the column.`
	`4945`	`+ * Phase 3 to physically get rid of the column. We formerly left the`
	`4946`	`+ * column in place physically, but this caused subtle problems. See`
	`4947`	`+ * http://archives.postgresql.org/pgsql-hackers/2009-02/msg00363.php`
`4946`	`4948`	`*/`
`4947`	`4949`	`if (attnum==ObjectIdAttributeNumber)`
`4948`	`4950`	`{`

Comments

(0)