Commit5a24efd

anarazel

authored and

Alexander Korotkov

committed

Move memory barrier in UnlockBufHdr to before releasing the lock.

This bug appears to have been introduced late in the development of4835458 ("Allow Pin/UnpinBuffer to operate in a lockfreemanner.").Found while debugging a bug which turned out to be independent of thecommit mentioned above.Backpatch: -

1 parent73adc14 commit5a24efdCopy full SHA for 5a24efd

File tree

1 file changed

-1

lines changed

src/include/storage
- buf_internals.h

1 file changed

-1

lines changed

`‎src/include/storage/buf_internals.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -230,8 +230,8 @@ typedef union BufferDescPadded`
`230`	`230`	`externuint32LockBufHdr(BufferDesc*desc);`
`231`	`231`	`#defineUnlockBufHdr(desc,s)\`
`232`	`232`	`do {\`
`233`		`-pg_atomic_write_u32(&(desc)->state, (s) & (~BM_LOCKED)); \`
`234`	`233`	`pg_write_barrier(); \`
	`234`	`+pg_atomic_write_u32(&(desc)->state, (s) & (~BM_LOCKED)); \`
`235`	`235`	`} while (0)`
`236`	`236`
`237`	`237`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5a24efd

File tree

1 file changed

1 file changed

`‎src/include/storage/buf_internals.h`

0 commit comments