NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit59f2971

committed

Fixes:

This patch forces postgres95 to assume any floating-point value is afloat8. It removes the requirement that you cast all floating-pointconstants to float8.We can remove alot of casts in the regression test after we are surethis works.If I have missed anything, would someone let me know. I have testedinserts of floating-point values into float8 fields, and it worked well.Casting the number to float4 showed the same precision loss as previousuncast values showed.Submitted by: Bruce Momjian <maillist@candle.pha.pa.us>

1 parent9b7eb28 commit59f2971Copy full SHA for 59f2971

File tree

2 files changed

-7

lines changed

src/backend/parser
- gram.y
- parse_query.c

2 files changed

-7

lines changed

`‎src/backend/parser/gram.y‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 1.5 1996/08/06 16:43:06 scrappy Exp $`
	`13`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 1.6 1996/08/13 01:29:33 scrappy Exp $`
`14`	`14`	`*`
`15`	`15`	`* HISTORY`
`16`	`16`	`* AUTHORDATEMAJOR EVENT`
`@@ -2112,7 +2112,7 @@ xlateSqlType(char *name)`
`2112`	`2112`	`return "int2";`
`2113`	`2113`	`else if (!strcasecmp(name, "float") \|\|`
`2114`	`2114`	`!strcasecmp(name, "real"))`
`2115`		`-return "float4";`
	`2115`	`+return "float8";`
`2116`	`2116`	`else`
`2117`	`2117`	`return name;`
`2118`	`2118`	`}`

`‎src/backend/parser/parse_query.c‎`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/Attic/parse_query.c,v 1.2 1996/07/19 07:24:09 scrappy Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/Attic/parse_query.c,v 1.3 1996/08/13 01:29:34 scrappy Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -594,13 +594,13 @@ make_const(Value *value)`
`594`	`594`
`595`	`595`	`caseT_Float:`
`596`	`596`	`{`
`597`		`-float32dummy;`
`598`		`-tp=type("float4");`
	`597`	`+float64dummy;`
	`598`	`+tp=type("float8");`
`599`	`599`
`600`		`-dummy= (float32)palloc(sizeof(float32data));`
	`600`	`+dummy= (float64)palloc(sizeof(float64data));`
`601`	`601`	`*dummy=floatVal(value);`
`602`	`602`
`603`		`-val=Float32GetDatum(dummy);`
	`603`	`+val=Float64GetDatum(dummy);`
`604`	`604`	`}`
`605`	`605`	`break;`
`606`	`606`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit59f2971

File tree

2 files changed

2 files changed

`‎src/backend/parser/gram.y‎`

`‎src/backend/parser/parse_query.c‎`

0 commit comments