NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit59de132

committed

Fix oversight in pg_dump's handling of extension configuration tables.

If an extension has not been selected to be dumped (perhaps because ofa --schema or --table switch), the contents of its configuration tablessurely should not get dumped either. Per gripe fromHubert Depesz Lubaczewski.

1 parent97dc3c8 commit59de132Copy full SHA for 59de132

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14179,13 +14179,18 @@ getExtensionMembership(Archive *fout, ExtensionInfo extinfo[],`
`14179`	`14179`	`*/`
`14180`	`14180`	`for (i=0;i<numExtensions;i++)`
`14181`	`14181`	`{`
`14182`		`-char*extconfig=extinfo[i].extconfig;`
`14183`		`-char*extcondition=extinfo[i].extcondition;`
	`14182`	`+ExtensionInfo*curext=&(extinfo[i]);`
	`14183`	`+char*extconfig=curext->extconfig;`
	`14184`	`+char*extcondition=curext->extcondition;`
`14184`	`14185`	`char**extconfigarray=NULL;`
`14185`	`14186`	`char**extconditionarray=NULL;`
`14186`	`14187`	`intnconfigitems;`
`14187`	`14188`	`intnconditionitems;`
`14188`	`14189`
	`14190`	`+/* Tables of not-to-be-dumped extensions shouldn't be dumped */`
	`14191`	`+if (!curext->dobj.dump)`
	`14192`	`+continue;`
	`14193`	`+`
`14189`	`14194`	`if (parsePGArray(extconfig,&extconfigarray,&nconfigitems)&&`
`14190`	`14195`	`parsePGArray(extcondition,&extconditionarray,&nconditionitems)&&`
`14191`	`14196`	`nconfigitems==nconditionitems)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit59de132

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments