Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit58a8285

Browse files
committed
Remove TypeName struct's timezone flag, which has been write-only storage
for a very long time --- in current usage it's entirely redundant with thename field.
1 parent20e82a7 commit58a8285

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

‎src/backend/nodes/copyfuncs.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* Portions Copyright (c) 1994, Regents of the University of California
1616
*
1717
* IDENTIFICATION
18-
* $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.389 2008/03/20 21:42:47 tgl Exp $
18+
* $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.390 2008/03/21 22:41:48 tgl Exp $
1919
*
2020
*-------------------------------------------------------------------------
2121
*/
@@ -1714,7 +1714,6 @@ _copyTypeName(TypeName *from)
17141714

17151715
COPY_NODE_FIELD(names);
17161716
COPY_SCALAR_FIELD(typeid);
1717-
COPY_SCALAR_FIELD(timezone);
17181717
COPY_SCALAR_FIELD(setof);
17191718
COPY_SCALAR_FIELD(pct_type);
17201719
COPY_NODE_FIELD(typmods);

‎src/backend/nodes/equalfuncs.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* Portions Copyright (c) 1994, Regents of the University of California
1919
*
2020
* IDENTIFICATION
21-
* $PostgreSQL: pgsql/src/backend/nodes/equalfuncs.c,v 1.319 2008/03/20 21:42:48 tgl Exp $
21+
* $PostgreSQL: pgsql/src/backend/nodes/equalfuncs.c,v 1.320 2008/03/21 22:41:48 tgl Exp $
2222
*
2323
*-------------------------------------------------------------------------
2424
*/
@@ -1753,7 +1753,6 @@ _equalTypeName(TypeName *a, TypeName *b)
17531753
{
17541754
COMPARE_NODE_FIELD(names);
17551755
COMPARE_SCALAR_FIELD(typeid);
1756-
COMPARE_SCALAR_FIELD(timezone);
17571756
COMPARE_SCALAR_FIELD(setof);
17581757
COMPARE_SCALAR_FIELD(pct_type);
17591758
COMPARE_NODE_FIELD(typmods);

‎src/backend/nodes/outfuncs.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.323 2008/03/20 21:42:48 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.324 2008/03/21 22:41:48 tgl Exp $
1212
*
1313
* NOTES
1414
* Every node type that can appear in stored rules' parsetrees *must*
@@ -1668,7 +1668,6 @@ _outTypeName(StringInfo str, TypeName *node)
16681668

16691669
WRITE_NODE_FIELD(names);
16701670
WRITE_OID_FIELD(typeid);
1671-
WRITE_BOOL_FIELD(timezone);
16721671
WRITE_BOOL_FIELD(setof);
16731672
WRITE_BOOL_FIELD(pct_type);
16741673
WRITE_NODE_FIELD(typmods);

‎src/backend/parser/gram.y

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*
1212
*
1313
* IDENTIFICATION
14-
* $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.609 2008/03/20 21:42:48 tgl Exp $
14+
* $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.610 2008/03/21 22:41:48 tgl Exp $
1515
*
1616
* HISTORY
1717
* AUTHORDATEMAJOR EVENT
@@ -7198,10 +7198,6 @@ ConstDatetime:
71987198
$$ = SystemTypeName("timestamptz");
71997199
else
72007200
$$ = SystemTypeName("timestamp");
7201-
/* XXX the timezone field seems to be unused
7202-
* - thomas 2001-09-06
7203-
*/
7204-
$$->timezone =$5;
72057201
$$->typmods = list_make1(makeIntConst($3));
72067202
$$->location =@1;
72077203
}
@@ -7211,10 +7207,6 @@ ConstDatetime:
72117207
$$ = SystemTypeName("timestamptz");
72127208
else
72137209
$$ = SystemTypeName("timestamp");
7214-
/* XXX the timezone field seems to be unused
7215-
* - thomas 2001-09-06
7216-
*/
7217-
$$->timezone =$2;
72187210
$$->location =@1;
72197211
}
72207212
| TIME'(' Iconst')' opt_timezone

‎src/include/nodes/parsenodes.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $PostgreSQL: pgsql/src/include/nodes/parsenodes.h,v 1.360 2008/03/20 21:42:48 tgl Exp $
10+
* $PostgreSQL: pgsql/src/include/nodes/parsenodes.h,v 1.361 2008/03/21 22:41:48 tgl Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -165,7 +165,6 @@ typedef struct TypeName
165165
NodeTagtype;
166166
List*names;/* qualified name (list of Value strings) */
167167
Oidtypeid;/* type identified by OID */
168-
booltimezone;/* timezone specified? */
169168
boolsetof;/* is a set? */
170169
boolpct_type;/* %TYPE specified? */
171170
List*typmods;/* type modifier expression(s) */

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp