Commit5766228

committed

Fix Xmax freeze conditions

I broke this in0ac5ad5; previously, freezing a tuple marked with anIS_MULTI xmax was not necessary.Per brokenness report from Jeff Janes.

1 parent335c5e9 commit5766228Copy full SHA for 5766228

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5113,10 +5113,11 @@ heap_freeze_tuple(HeapTupleHeader tuple, TransactionId cutoff_xid,`
`5113`	`5113`	`* cutoff; it doesn't remove dead members of a very old multixact.`
`5114`	`5114`	`*/`
`5115`	`5115`	`xid=HeapTupleHeaderGetRawXmax(tuple);`
`5116`		`-if (TransactionIdIsNormal(xid)&&`
`5117`		`-(((!(tuple->t_infomask&HEAP_XMAX_IS_MULTI)&&`
`5118`		`-TransactionIdPrecedes(xid,cutoff_xid)))\|\|`
`5119`		`-MultiXactIdPrecedes(xid,cutoff_multi)))`
	`5116`	`+if ((tuple->t_infomask&HEAP_XMAX_IS_MULTI) ?`
	`5117`	`+(MultiXactIdIsValid(xid)&&`
	`5118`	`+MultiXactIdPrecedes(xid,cutoff_multi)) :`
	`5119`	`+(TransactionIdIsNormal(xid)&&`
	`5120`	`+TransactionIdPrecedes(xid,cutoff_xid)))`
`5120`	`5121`	`{`
`5121`	`5122`	`HeapTupleHeaderSetXmax(tuple,InvalidTransactionId);`
`5122`	`5123`

Comments

(0)