NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit561ec76

committed

psql: Fix invalid memory access

Due to an apparent thinko, when printing a table in expanded mode(\x), space would be allocated for 1 slot plus 1 byte per line,instead of 1 slot per line plus 1 slot for the NULL terminator. Whenthe line count is small, reading or writing the terminator wouldtherefore access memory beyond what was allocated.

1 parentf9325df commit561ec76Copy full SHA for 561ec76

File tree

1 file changed

-2

lines changed

src/bin/psql
- print.c

1 file changed

-2

lines changed

`‎src/bin/psql/print.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1210,8 +1210,8 @@ print_aligned_vertical(const printTableContent cont, FILE fout)`
`1210`	`1210`	`* We now have all the information we need to setup the formatting`
`1211`	`1211`	`* structures`
`1212`	`1212`	`*/`
`1213`		`-dlineptr=pg_local_malloc((sizeof(dlineptr)+1)dheight);`
`1214`		`-hlineptr=pg_local_malloc((sizeof(hlineptr)+1)hheight);`
	`1213`	`+dlineptr=pg_local_malloc((sizeof(dlineptr))(dheight+1));`
	`1214`	`+hlineptr=pg_local_malloc((sizeof(hlineptr))(hheight+1));`
`1215`	`1215`
`1216`	`1216`	`dlineptr->ptr=pg_local_malloc(dformatsize);`
`1217`	`1217`	`hlineptr->ptr=pg_local_malloc(hformatsize);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit561ec76

File tree

1 file changed

1 file changed

`‎src/bin/psql/print.c`

0 commit comments