NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit5577ca5

committed

Remove bogus entries in gist point_ops operator class.

These entries could never be matched to an index clause because they don'thave the index datatype on the left-hand side of the operator. (Theircommutators are in the opclass, which is sensible, but that doesn't meanthese operators should be.) Spotted by a test that I recently added toopr_sanity to catch exactly this type of thinko. AFAICT there is no codein gistproc.c that is specifically meant to cover these cases, so nothingto remove at that level.

1 parentdd45d3a commit5577ca5Copy full SHA for 5577ca5

File tree

3 files changed

-12

lines changed

src
- include/catalog
  - catversion.h
  - pg_amop.h
- test/regress/expected
  - opr_sanity.out

3 files changed

-12

lines changed

`‎src/include/catalog/catversion.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,6 @@`
`53`	`53`	`*/`
`54`	`54`
`55`	`55`	`/yyyymmddN /`
`56`		`-#defineCATALOG_VERSION_NO201112171`
	`56`	`+#defineCATALOG_VERSION_NO201112172`
`57`	`57`
`58`	`58`	`#endif`

`‎src/include/catalog/pg_amop.h`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -605,11 +605,8 @@ DATA(insert (1029 600 600 5 s508 783 0 ));`
`605`	`605`	`DATA(insert (102960060010s5097830 ));`
`606`	`606`	`DATA(insert (10296006006s5107830 ));`
`607`	`607`	`DATA(insert (102960060015o5177831970 ));`
`608`		`-DATA(insert (102960360027s4337830 ));`
`609`	`608`	`DATA(insert (102960060328s5117830 ));`
`610`		`-DATA(insert (102960460047s7577830 ));`
`611`	`609`	`DATA(insert (102960060448s7567830 ));`
`612`		`-DATA(insert (102971860067s7597830 ));`
`613`	`610`	`DATA(insert (102960071868s7587830 ));`
`614`	`611`
`615`	`612`

`‎src/test/regress/expected/opr_sanity.out`

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1041,11 +1041,8 @@ ORDER BY 1, 2, 3;`
`1041`	`1041`	`783 \| 15 \| <->`
`1042`	`1042`	`783 \| 16 \| @>`
`1043`	`1043`	`783 \| 18 \| =`
`1044`		`- 783 \| 27 \| @>`
`1045`	`1044`	`783 \| 28 \| <@`
`1046`		`- 783 \| 47 \| @>`
`1047`	`1045`	`783 \| 48 \| <@`
`1048`		`- 783 \| 67 \| @>`
`1049`	`1046`	`783 \| 68 \| <@`
`1050`	`1047`	`2742 \| 1 \| &&`
`1051`	`1048`	`2742 \| 1 \| @@`
`@@ -1068,7 +1065,7 @@ ORDER BY 1, 2, 3;`
`1068`	`1065`	`4000 \| 12 \| <=`
`1069`	`1066`	`4000 \| 14 \| >=`
`1070`	`1067`	`4000 \| 15 \| >`
`1071`		`-(58 rows)`
	`1068`	`+(55 rows)`
`1072`	`1069`
`1073`	`1070`	`-- Check that all opclass search operators have selectivity estimators.`
`1074`	`1071`	`-- This is not absolutely required, but it seems a reasonable thing`
`@@ -1105,10 +1102,7 @@ WHERE NOT EXISTS(SELECT 1 FROM pg_opclass AS p2`
`1105`	`1102`	`AND binary_coercible(p2.opcintype, p1.amoplefttype));`
`1106`	`1103`	`amopfamily \| amopstrategy \| amopopr`
`1107`	`1104`	`------------+--------------+---------`
`1108`		`- 1029 \| 27 \| 433`
`1109`		`- 1029 \| 47 \| 757`
`1110`		`- 1029 \| 67 \| 759`
`1111`		`-(3 rows)`
	`1105`	`+(0 rows)`
`1112`	`1106`
`1113`	`1107`	`-- Operators that are primary members of opclasses must be immutable (else`
`1114`	`1108`	`-- it suggests that the index ordering isn't fixed). Operators that are`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5577ca5

File tree

3 files changed

3 files changed

`‎src/include/catalog/catversion.h`

`‎src/include/catalog/pg_amop.h`

`‎src/test/regress/expected/opr_sanity.out`

0 commit comments