Commit556110f

committed

copy_relation_data was mistakenly assuming that the source relation

would always be already open at the smgr level. Per bug report fromFabien Coelho.

1 parentb4456e6 commit556110fCopy full SHA for 556110f

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.129 2004/08/29 05:06:41 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.130 2004/08/31 15:56:39 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -5434,7 +5434,7 @@ ATExecSetTableSpace(Oid tableOid, Oid newTableSpace)`
`5434`	`5434`	`staticvoid`
`5435`	`5435`	`copy_relation_data(Relationrel,SMgrRelationdst)`
`5436`	`5436`	`{`
`5437`		`-SMgrRelationsrc=rel->rd_smgr;`
	`5437`	`+SMgrRelationsrc;`
`5438`	`5438`	`booluse_wal;`
`5439`	`5439`	`BlockNumbernblocks;`
`5440`	`5440`	`BlockNumberblkno;`
`@@ -5457,6 +5457,9 @@ copy_relation_data(Relation rel, SMgrRelation dst)`
`5457`	`5457`	`use_wal=XLogArchivingActive()&& !rel->rd_istemp;`
`5458`	`5458`
`5459`	`5459`	`nblocks=RelationGetNumberOfBlocks(rel);`
	`5460`	`+/* RelationGetNumberOfBlocks will certainly have opened rd_smgr */`
	`5461`	`+src=rel->rd_smgr;`
	`5462`	`+`
`5460`	`5463`	`for (blkno=0;blkno<nblocks;blkno++)`
`5461`	`5464`	`{`
`5462`	`5465`	`smgrread(src,blkno,buf);`

Comments

(0)