NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit546d684

Neil Conway

committed

Add a comment noting that heap_copytuple_with_tuple() results in a

HeapTuple that is no longer allocated as a single palloc() block; ifused carelessly, this might result in a subsequent memory leak afterheap_freetuple().

1 parent0c6f167 commit546d684Copy full SHA for 546d684

File tree

1 file changed

-1

lines changed

src/backend/access/common
- heaptuple.c

1 file changed

-1

lines changed

`‎src/backend/access/common/heaptuple.c‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`*`
`17`	`17`	`*`
`18`	`18`	`* IDENTIFICATION`
`19`		`- * $PostgreSQL: pgsql/src/backend/access/common/heaptuple.c,v 1.111 2006/10/04 00:29:47 momjian Exp $`
	`19`	`+ * $PostgreSQL: pgsql/src/backend/access/common/heaptuple.c,v 1.112 2006/11/23 05:27:18 neilc Exp $`
`20`	`20`	`*`
`21`	`21`	`*-------------------------------------------------------------------------`
`22`	`22`	`*/`
`@@ -631,6 +631,9 @@ heap_copytuple(HeapTuple tuple)`
`631`	`631`	`*heap_copytuple_with_tuple`
`632`	`632`	`*`
`633`	`633`	`*copy a tuple into a caller-supplied HeapTuple management struct`
	`634`	`+ *`
	`635`	`+ * Note that after calling this function, the "dest" HeapTuple will not be`
	`636`	`+ * allocated as a single palloc() block (unlike with heap_copytuple()).`
`634`	`637`	`* ----------------`
`635`	`638`	`*/`
`636`	`639`	`void`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit546d684

File tree

1 file changed

1 file changed

`‎src/backend/access/common/heaptuple.c‎`

0 commit comments