Commit5425c0f

committed

pathman: warnings fix, documentation

1 parent1aa7e48 commit5425c0fCopy full SHA for 5425c0f

File tree

+14

-12

lines changed

+14

-12

lines changed

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -37,8 +37,7 @@ Based on partitioning type and operator the `pg_pathman` searches corresponding
`37`	`37`
`38`	`38`	`To install pg_pathman run in psql:`
`39`	`39`	```
`40`		`-CREATE SCHEMA pathman;`
`41`		`-CREATE EXTENSION pg_pathman SCHEMA pathman;`
	`40`	`+CREATE EXTENSION pg_pathman;`
`42`	`41`	```
`43`	`42`	`Then modify shared_preload_libraries parameter in postgres.conf as following:`
`44`	`43`	```
`@@ -121,7 +120,7 @@ CREATE TABLE hash_rel (`
`121`	`120`	`value INTEGER);`
`122`	`121`	`INSERT INTO hash_rel (value) SELECT g FROM generate_series(1, 10000) as g;`
`123`	`122`	```
`124`		`-Then run create_hash_partitions() function with appropriate arguments:`
	`123`	`+If partitions are supposed to have indexes, then they should be created for parent table before partitioning. In this case pg_pathman will automaticaly create indexes for partitions.Then run create_hash_partitions() function with appropriate arguments:`
`125`	`124`	```
`126`	`125`	`SELECT create_hash_partitions('hash_rel', 'value', 100);`
`127`	`126`	```

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,7 @@ WHERE id = 150`
`38`	`38`
`39`	`39`	`Для установки pg_pathman выполните в командной строке:`
`40`	`40`	```
`41`		`-CREATE SCHEMA pathman;`
`42`		`-CREATE EXTENSION pg_pathman SCHEMA pathman;`
	`41`	`+CREATE EXTENSION pg_pathman;`
`43`	`42`
`44`	`43`	```
`45`	`44`	`Затем модифицируйте параметр shared_preload_libraries в конфигурационном файле postgres.conf:`
`@@ -123,7 +122,7 @@ CREATE TABLE hash_rel (`
`123`	`122`	`value INTEGER);`
`124`	`123`	`INSERT INTO hash_rel (value) SELECT g FROM generate_series(1, 10000) as g;`
`125`	`124`	```
`126`		-Разобьем таблицу`hash_rel` на 100 секций по полю`value`:
	`125`	+Если дочерние секции подразумевают наличие индексов, то стоит их создать в родительской таблице до разбиения. Тогда при разбиении pg_pathman автоматически создаст соответствующие индексы в дочерних.таблицах.Разобьем таблицу`hash_rel` на 100 секций по полю`value`:
`127`	`126`	```
`128`	`127`	`SELECT create_hash_partitions('hash_rel', 'value', 100);`
`129`	`128`	```

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ load_check_constraints(Oid parent_oid)`
`208`	`208`	`{`
`209`	`209`	`SPITupleTable*tuptable=SPI_tuptable;`
`210`	`210`	`Oid*children;`
`211`		`-RangeEntry*ranges;`
	`211`	`+RangeEntry*ranges=NULL;`
`212`	`212`	`Datummin;`
`213`	`213`	`Datummax;`
`214`	`214`	`inthash;`

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -644,9 +644,9 @@ handle_binary_opexpr(const PartRelationInfo prel, WrapperNode result,`
`644`	`644`	`if (rangerel!=NULL)`
`645`	`645`	`{`
`646`	`646`	`RangeEntry*re;`
`647`		`-boolfound= false,`
`648`		`-lossy= false;`
	`647`	`+boollossy= false;`
`649`	`648`	`#ifdefUSE_ASSERT_CHECKING`
	`649`	`+boolfound= false;`
`650`	`650`	`intcounter=0;`
`651`	`651`	`#endif`
`652`	`652`	`intstartidx=0,`
`@@ -718,7 +718,9 @@ handle_binary_opexpr(const PartRelationInfo prel, WrapperNode result,`
`718`	`718`	`lossy= false;`
`719`	`719`	`else`
`720`	`720`	`lossy= true;`
	`721`	`+#ifdefUSE_ASSERT_CHECKING`
`721`	`722`	`found= true;`
	`723`	`+#endif`
`722`	`724`	`break;`
`723`	`725`	`}`
`724`	`726`
`@@ -808,8 +810,10 @@ range_binary_search(const RangeRelation rangerel, FmgrInfo cmp_func, Datum val`
`808`	`810`	`cmp_max,`
`809`	`811`	`i=0,`
`810`	`812`	`startidx=0,`
`811`		`-endidx=rangerel->ranges.length-1,`
`812`		`-counter=0;`
	`813`	`+endidx=rangerel->ranges.length-1;`
	`814`	`+#ifdefUSE_ASSERT_CHECKING`
	`815`	`+intcounter=0;`
	`816`	`+#endif`
`813`	`817`
`814`	`818`	`*foundPtr= false;`
`815`	`819`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ irange_list_union(List a, List b)`
`52`	`52`
`53`	`53`	`while (ca\|\|cb)`
`54`	`54`	`{`
`55`		`-IndexRangenext;`
	`55`	`+IndexRangenext=0;`
`56`	`56`
`57`	`57`	`/* Fetch next range with lesser lower bound */`
`58`	`58`	`if (ca&&cb)`

Comments

(0)