NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit53c7cff

committed

Ensure gatherstate->nextreader is properly initialized.

The previously code worked OK as long as a Gather node was neverrescanned, or if it was rescanned, as long as it got at least asmany workers on rescan as it had originally. But if the numberof workers ever decreased on a rescan, then it could crash.Andreas Seltenreich

1 parent093129c commit53c7cffCopy full SHA for 53c7cff

File tree

1 file changed

-0

lines changed

src/backend/executor
- nodeGather.c

1 file changed

-0

lines changed

`‎src/backend/executor/nodeGather.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,6 +173,7 @@ ExecGather(GatherState *node)`
`173`	`173`	`if (pcxt->nworkers_launched>0)`
`174`	`174`	`{`
`175`	`175`	`node->nreaders=0;`
	`176`	`+node->nextreader=0;`
`176`	`177`	`node->reader=`
`177`	`178`	`palloc(pcxt->nworkers_launchedsizeof(TupleQueueReader));`
`178`	`179`
`@@ -335,6 +336,7 @@ gather_readnext(GatherState *gatherstate)`
`335`	`336`	`CHECK_FOR_INTERRUPTS();`
`336`	`337`
`337`	`338`	`/* Attempt to read a tuple, but don't block if none is available. */`
	`339`	`+Assert(gatherstate->nextreader<gatherstate->nreaders);`
`338`	`340`	`reader=gatherstate->reader[gatherstate->nextreader];`
`339`	`341`	`tup=TupleQueueReaderNext(reader, true,&readerdone);`
`340`	`342`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit53c7cff

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeGather.c`

0 commit comments