Commit5225c66

committed

Clarify policy on marking inherited constraints as valid.

Amit Langote and Robert Haas

1 parent5c6df67 commit5225c66Copy full SHA for 5225c66

File tree

+11

-6

lines changed

+11

-6

lines changed

Lines changed: 9 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1028,11 +1028,15 @@ ALTER TABLE ALL IN TABLESPACE <replaceable class="PARAMETER">name</replaceable>`
`1028`	`1028`
`1029`	`1029`	`<para>`
`1030`	`1030`	`If a table has any descendant tables, it is not permitted to add,`
`1031`		`- rename, or change the type of a column, or rename an inherited constraint`
`1032`		`- in the parent table without doing`
`1033`		`- the same to the descendants. That is, <command>ALTER TABLE ONLY</command>`
`1034`		`- will be rejected. This ensures that the descendants always have`
`1035`		`- columns matching the parent.`
	`1031`	`+ rename, or change the type of a column in the parent table without doing`
	`1032`	`+ same to the descendants. This ensures that the descendants always have`
	`1033`	`+ columns matching the parent. Similarly, a constraint cannot be renamed`
	`1034`	`+ in the parent without also renaming it in all descendents, so that`
	`1035`	`+ constraints also match between the parent and its descendents.`
	`1036`	`+ Also, because selecting from the parent also selects from its descendents,`
	`1037`	`+ a constraint on the parent cannot be marked valid unless it is also marked`
	`1038`	`+ valid for those descendents. In all of these cases, <command>ALTER TABLE`
	`1039`	`+ ONLY</command> will be rejected.`
`1036`	`1040`	`</para>`
`1037`	`1041`
`1038`	`1042`	`<para>`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6908,7 +6908,8 @@ ATExecValidateConstraint(Relation rel, char *constrName, bool recurse,`
`6908`	`6908`
`6909`	`6909`	`/*`
`6910`	`6910`	`* If we are told not to recurse, there had better not be any`
`6911`		`- * child tables; else the addition would put them out of step.`
	`6911`	`+ * child tables, because we can't mark the constraint on the`
	`6912`	`+ * parent valid unless it is valid for all child tables.`
`6912`	`6913`	`*/`
`6913`	`6914`	`if (!recurse)`
`6914`	`6915`	`ereport(ERROR,`

Comments

(0)