NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit5201002

committed

Avoid spurious Hot Standby conflicts from btree delete records.

Similar conflicts were already avoided for related record types.Massive over-caution resulted in a usability bug. Clear theoreticalbasis for doing this is now confirmed by me.Request to remove from Heikki (twice), over-caution by me.

1 parent357edc9 commit5201002Copy full SHA for 5201002

File tree

1 file changed

-13

lines changed

src/backend/storage/ipc
- standby.c

1 file changed

-13

lines changed

`‎src/backend/storage/ipc/standby.c‎`

Lines changed: 5 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -266,21 +266,13 @@ ResolveRecoveryConflictWithSnapshot(TransactionId latestRemovedXid, RelFileNode`
`266`	`266`
`267`	`267`	`/*`
`268`	`268`	`* If we get passed InvalidTransactionId then we are a little surprised,`
`269`		`- * but it is theoretically possible, so spit out a DEBUG1 message, but not`
`270`		`- * one that needs translating.`
`271`		`- *`
`272`		`- * We grab latestCompletedXid instead because this is the very latest`
`273`		`- * value it could ever be.`
	`269`	`+ * but it is theoretically possible in normal running. It also happens`
	`270`	`+ * when replaying already applied WAL records after a standby crash or`
	`271`	`+ * restart. If latestRemovedXid is invalid then there is no conflict. That`
	`272`	`+ * rule applies across all record types that suffer from this conflict.`
`274`	`273`	`*/`
`275`	`274`	`if (!TransactionIdIsValid(latestRemovedXid))`
`276`		`-{`
`277`		`-elog(DEBUG1,"invalid latestremovexXid reported, using latestcompletedxid instead");`
`278`		`-`
`279`		`-LWLockAcquire(ProcArrayLock,LW_SHARED);`
`280`		`-latestRemovedXid=ShmemVariableCache->latestCompletedXid;`
`281`		`-LWLockRelease(ProcArrayLock);`
`282`		`-}`
`283`		`-Assert(TransactionIdIsValid(latestRemovedXid));`
	`275`	`+return;`
`284`	`276`
`285`	`277`	`backends=GetConflictingVirtualXIDs(latestRemovedXid,`
`286`	`278`	`node.dbNode);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5201002

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/standby.c‎`

0 commit comments