Commit5024044

committed

C comments: improve description of relfilenode uniqueness

Report by Antonin Houska

1 parent11d205e commit5024044Copy full SHA for 5024044

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -408,8 +408,8 @@ GetNewOidWithIndex(Relation relation, Oid indexId, AttrNumber oidcolumn)`
`408`	`408`
`409`	`409`	`/*`
`410`	`410`	`* GetNewRelFileNode`
`411`		`- *Generate a new relfilenode number that is unique within the given`
`412`		`- *tablespace.`
	`411`	`+ *Generate a new relfilenode number that is unique within the`
	`412`	`+ *database of the giventablespace.`
`413`	`413`	`*`
`414`	`414`	`* If the relfilenode will also be used as the relation's OID, pass the`
`415`	`415`	`* opened pg_class catalog, and this routine will guarantee that the result`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9078,8 +9078,8 @@ ATExecSetTableSpace(Oid tableOid, Oid newTableSpace, LOCKMODE lockmode)`
`9078`	`9078`	`FlushRelationBuffers(rel);`
`9079`	`9079`
`9080`	`9080`	`/*`
`9081`		`- * Relfilenodes are not unique across tablespaces, so we need to allocate`
`9082`		`- * a new one in the new tablespace.`
	`9081`	`+ * Relfilenodes are not uniquein databasesacross tablespaces, so we`
	`9082`	`+ *need to allocatea new one in the new tablespace.`
`9083`	`9083`	`*/`
`9084`	`9084`	`newrelfilenode=GetNewRelFileNode(newTableSpace,NULL,`
`9085`	`9085`	`rel->rd_rel->relpersistence);`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ typedef enum ForkNumber`
`55`	`55`	`* relNode identifies the specific relation. relNode corresponds to`
`56`	`56`	`* pg_class.relfilenode (NOT pg_class.oid, because we need to be able`
`57`	`57`	`* to assign new physical files to relations in some situations).`
`58`		`- * Notice that relNode is only unique within a particular tablespace.`
	`58`	`+ * Notice that relNode is only unique within a database in a particular`
	`59`	`+ * tablespace.`
`59`	`60`	`*`
`60`	`61`	`* Note: spcNode must be GLOBALTABLESPACE_OID if and only if dbNode is`
`61`	`62`	`* zero. We support shared relations only in the "global" tablespace.`

Comments

(0)