Commit4fff9d7

committed

Document issues with non-default tablespaces and pg_dumpall restores.

Backpatch documentation addition to 8.1.X.

1 parentb055f00 commit4fff9d7Copy full SHA for 4fff9d7

File tree

+18

-3

lines changed

+18

-3

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<!--`
`2`		`-$PostgreSQL: pgsql/doc/src/sgml/ref/pg_dumpall.sgml,v 1.55 2005/11/01 21:09:50 tgl Exp $`
	`2`	`+$PostgreSQL: pgsql/doc/src/sgml/ref/pg_dumpall.sgml,v 1.56 2006/06/16 22:01:17 momjian Exp $`
`3`	`3`	`PostgreSQL documentation`
`4`	`4`	`-->`
`5`	`5`
`@@ -377,6 +377,13 @@ PostgreSQL documentation`
`377`	`377`	`databases.`
`378`	`378`	`</para>`
`379`	`379`
	`380`	`+ <para>`
	`381`	`+ <application>pg_dumpall</application> requires all needed`
	`382`	`+ tablespace directories to exist before the restore or`
	`383`	`+ database creation will fail for databases in non-default`
	`384`	`+ locations.`
	`385`	`+ </para>`
	`386`	`+`
`380`	`387`	`</refsect1>`
`381`	`388`
`382`	`389`

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Portions Copyright (c) 1994, Regents of the University of California`
`7`	`7`	`*`
`8`	`8`	`*`
`9`		`- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.79 2006/06/07 22:24:45 momjian Exp $`
	`9`	`+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.80 2006/06/16 22:01:17 momjian Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -888,7 +888,15 @@ dumpCreateDB(PGconn *conn)`
`888`	`888`	`appendPQExpBuffer(buf," ENCODING = ");`
`889`	`889`	`appendStringLiteralConn(buf,dbencoding,conn);`
`890`	`890`
`891`		`-/* Output tablespace if it isn't default */`
	`891`	`+/*`
	`892`	`+ *Output tablespace if it isn't the default. For default, it`
	`893`	`+ *uses the default from the template database. If tablespace`
	`894`	`+ *is specified and tablespace creation failed earlier,`
	`895`	`+ *(e.g. no such directory), the database creation will fail`
	`896`	`+ *too. One solution would be to use 'SET default_tablespace'`
	`897`	`+ *like we do in pg_dump for setting non-default database`
	`898`	`+ *locations.`
	`899`	`+ */`
`892`	`900`	`if (strcmp(dbtablespace,"pg_default")!=0)`
`893`	`901`	`appendPQExpBuffer(buf," TABLESPACE = %s",`
`894`	`902`	`fmtId(dbtablespace));`

Comments

(0)