NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit4ee5c40

committed

Don't try to use a unopened relation

Commit4c9d090 mistakenly introduced a call toTransferPredicateLocksToHeapRelation() on an index relation that hadbeen closed a few lines above. Moving up an index_open() call that'sbelow is enough to fix the problem.Discovered by me while testing an unrelated patch.

1 parentc90dcd6 commit4ee5c40Copy full SHA for 4ee5c40

File tree

1 file changed

-3

lines changed

src/backend/catalog
- index.c

1 file changed

-3

lines changed

`‎src/backend/catalog/index.c‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1475,6 +1475,8 @@ index_drop(Oid indexId, bool concurrent)`
`1475`	`1475`	`* conflicts with existing predicate locks, so now is the time to move`
`1476`	`1476`	`* them to the heap relation.`
`1477`	`1477`	`*/`
	`1478`	`+userHeapRelation=heap_open(heapId,ShareUpdateExclusiveLock);`
	`1479`	`+userIndexRelation=index_open(indexId,ShareUpdateExclusiveLock);`
`1478`	`1480`	`TransferPredicateLocksToHeapRelation(userIndexRelation);`
`1479`	`1481`
`1480`	`1482`	`/*`
`@@ -1484,9 +1486,6 @@ index_drop(Oid indexId, bool concurrent)`
`1484`	`1486`	`*/`
`1485`	`1487`	`indexRelation=heap_open(IndexRelationId,RowExclusiveLock);`
`1486`	`1488`
`1487`		`-userHeapRelation=heap_open(heapId,ShareUpdateExclusiveLock);`
`1488`		`-userIndexRelation=index_open(indexId,ShareUpdateExclusiveLock);`
`1489`		`-`
`1490`	`1489`	`tuple=SearchSysCacheCopy1(INDEXRELID,`
`1491`	`1490`	`ObjectIdGetDatum(indexId));`
`1492`	`1491`	`if (!HeapTupleIsValid(tuple))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4ee5c40

File tree

1 file changed

1 file changed

`‎src/backend/catalog/index.c‎`

0 commit comments