NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit4bfc5f1

committed

Fix off-by-one bug in LWLockRegisterTranche().

Original coding failed to enlarge the array as required ifthe requested tranche_id was equal to LWLockTranchesAllocated.In passing, fix poor style of not casting the result of (re)palloc.

1 parent49137ec commit4bfc5f1Copy full SHA for 4bfc5f1

File tree

1 file changed

-5

lines changed

src/backend/storage/lmgr
- lwlock.c

1 file changed

-5

lines changed

`‎src/backend/storage/lmgr/lwlock.c‎`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -350,8 +350,9 @@ CreateLWLocks(void)`
`350`	`350`	`if (LWLockTrancheArray==NULL)`
`351`	`351`	`{`
`352`	`352`	`LWLockTranchesAllocated=16;`
`353`		`-LWLockTrancheArray=MemoryContextAlloc(TopMemoryContext,`
`354`		`-LWLockTranchesAllocatedsizeof(LWLockTranche));`
	`353`	`+LWLockTrancheArray= (LWLockTranche**)`
	`354`	`+MemoryContextAlloc(TopMemoryContext,`
	`355`	`+LWLockTranchesAllocatedsizeof(LWLockTranche));`
`355`	`356`	`}`
`356`	`357`
`357`	`358`	`MainLWLockTranche.name="main";`
`@@ -423,11 +424,12 @@ LWLockRegisterTranche(int tranche_id, LWLockTranche *tranche)`
`423`	`424`	`{`
`424`	`425`	`inti=LWLockTranchesAllocated;`
`425`	`426`
`426`		`-while (i<tranche_id)`
	`427`	`+while (i <=tranche_id)`
`427`	`428`	`i *=2;`
`428`	`429`
`429`		`-LWLockTrancheArray=repalloc(LWLockTrancheArray,`
`430`		`-isizeof(LWLockTranche));`
	`430`	`+LWLockTrancheArray= (LWLockTranche**)`
	`431`	`+repalloc(LWLockTrancheArray,`
	`432`	`+isizeof(LWLockTranche));`
`431`	`433`	`LWLockTranchesAllocated=i;`
`432`	`434`	`}`
`433`	`435`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4bfc5f1

File tree

1 file changed

1 file changed

`‎src/backend/storage/lmgr/lwlock.c‎`

0 commit comments