NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit490e9a9

committed

Fix two valgrind issues in slab allocator.

During allocation VALGRIND_MAKE_MEM_DEFINED was called with a pointeras size. That kind of works, but makes valgrind exceedingly slow forworkloads involving the slab allocator.Secondly there was an access to memory marked as unreachable withinSlabCheck(). Fix that too.Author: Tomas VondraDiscussion:https://postgr.es/m/a6543b6d-6015-99b1-63ef-3ed55a76a730@2ndquadrant.com

1 parente75a786 commit490e9a9Copy full SHA for 490e9a9

File tree

1 file changed

-1

lines changed

src/backend/utils/mmgr
- slab.c

1 file changed

-1

lines changed

`‎src/backend/utils/mmgr/slab.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ SlabAlloc(MemoryContext context, Size size)`
`403`	`403`	`* Remove the chunk from the freelist head. The index of the next free`
`404`	`404`	`* chunk is stored in the chunk itself.`
`405`	`405`	`*/`
`406`		`-VALGRIND_MAKE_MEM_DEFINED(chunk,SlabChunkGetPointer(chunk));`
	`406`	`+VALGRIND_MAKE_MEM_DEFINED(SlabChunkGetPointer(chunk),sizeof(int32));`
`407`	`407`	`block->firstFreeChunk=(int32)SlabChunkGetPointer(chunk);`
`408`	`408`
`409`	`409`	`Assert(block->firstFreeChunk >=0);`
`@@ -725,6 +725,7 @@ SlabCheck(MemoryContext context)`
`725`	`725`
`726`	`726`	`/* read index of the next free chunk */`
`727`	`727`	`chunk=SlabBlockGetChunk(slab,block,idx);`
	`728`	`+VALGRIND_MAKE_MEM_DEFINED(SlabChunkGetPointer(chunk),sizeof(int32));`
`728`	`729`	`idx=(int32)SlabChunkGetPointer(chunk);`
`729`	`730`	`}`
`730`	`731`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit490e9a9

File tree

1 file changed

1 file changed

`‎src/backend/utils/mmgr/slab.c`

0 commit comments