NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit474ff21

committed

De-kludge contrib/btree_gin for collations.

Using DEFAULT_COLLATION_OID in the comparePartial functions was not onlya lame hack, but outright wrong, because the compare functions forcollation-aware types were already responding to the declared indexcollation. So comparePartial would have the wrong expectation aboutthe index's sort order, possibly leading to missing matches for prefixsearches.

1 parent78e7e20 commit474ff21Copy full SHA for 474ff21

File tree

1 file changed

-2

lines changed

contrib/btree_gin
- btree_gin.c

1 file changed

-2

lines changed

`‎contrib/btree_gin/btree_gin.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@`
`7`	`7`
`8`	`8`	`#include"fmgr.h"`
`9`	`9`	`#include"access/skey.h"`
`10`		`-#include"catalog/pg_collation.h"`
`11`	`10`	`#include"utils/builtins.h"`
`12`	`11`	`#include"utils/bytea.h"`
`13`	`12`	`#include"utils/cash.h"`
`@@ -123,7 +122,7 @@ gin_compare_prefix_##type(PG_FUNCTION_ARGS)\`
`123`	`122`	`\`
`124`	`123`	`cmp = DatumGetInt32(DirectFunctionCall2Coll(\`
`125`	`124`	`TypeInfo_##type.typecmp,\`
`126`		`-DEFAULT_COLLATION_OID,\`
	`125`	`+PG_GET_COLLATION(),\`
`127`	`126`	`(data->strategy == BTLessStrategyNumber \|\|\`
`128`	`127`	`data->strategy == BTLessEqualStrategyNumber)\`
`129`	`128`	`? data->datum : a,\`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit474ff21

File tree

1 file changed

1 file changed

`‎contrib/btree_gin/btree_gin.c`

0 commit comments