NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit47386fe

committed

Use floor() not rint() when reducing precision of fractional seconds in

timestamp_trunc, timestamptz_trunc, and interval_trunc(). This changeonly affects the float-datetime case; the integer-datetime case alreadybehaved like truncation instead of rounding. Per gripe from Mario Splivalo.This is a pre-existing issue but I'm choosing not to backpatch, becauseit's such a corner case and there have not been prior complaints. Theissue is largely moot anyway given the trend towards integer datetimes.

1 parent44886bd commit47386feCopy full SHA for 47386fe

File tree

1 file changed

-7

lines changed

src/backend/utils/adt
- timestamp.c

1 file changed

-7

lines changed

`‎src/backend/utils/adt/timestamp.c‎`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.201 2009/06/11 14:49:04 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.202 2009/07/06 20:29:23 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -3338,13 +3338,13 @@ timestamp_trunc(PG_FUNCTION_ARGS)`
`3338`	`3338`	`#ifdefHAVE_INT64_TIMESTAMP`
`3339`	`3339`	`fsec= (fsec /1000)*1000;`
`3340`	`3340`	`#else`
`3341`		`-fsec=rint(fsec*1000) /1000;`
	`3341`	`+fsec=floor(fsec*1000) /1000;`
`3342`	`3342`	`#endif`
`3343`	`3343`	`break;`
`3344`	`3344`
`3345`	`3345`	`caseDTK_MICROSEC:`
`3346`	`3346`	`#ifndefHAVE_INT64_TIMESTAMP`
`3347`		`-fsec=rint(fsec*1000000) /1000000;`
	`3347`	`+fsec=floor(fsec*1000000) /1000000;`
`3348`	`3348`	`#endif`
`3349`	`3349`	`break;`
`3350`	`3350`
`@@ -3494,12 +3494,12 @@ timestamptz_trunc(PG_FUNCTION_ARGS)`
`3494`	`3494`	`#ifdefHAVE_INT64_TIMESTAMP`
`3495`	`3495`	`fsec= (fsec /1000)*1000;`
`3496`	`3496`	`#else`
`3497`		`-fsec=rint(fsec*1000) /1000;`
	`3497`	`+fsec=floor(fsec*1000) /1000;`
`3498`	`3498`	`#endif`
`3499`	`3499`	`break;`
`3500`	`3500`	`caseDTK_MICROSEC:`
`3501`	`3501`	`#ifndefHAVE_INT64_TIMESTAMP`
`3502`		`-fsec=rint(fsec*1000000) /1000000;`
	`3502`	`+fsec=floor(fsec*1000000) /1000000;`
`3503`	`3503`	`#endif`
`3504`	`3504`	`break;`
`3505`	`3505`
`@@ -3591,12 +3591,12 @@ interval_trunc(PG_FUNCTION_ARGS)`
`3591`	`3591`	`#ifdefHAVE_INT64_TIMESTAMP`
`3592`	`3592`	`fsec= (fsec /1000)*1000;`
`3593`	`3593`	`#else`
`3594`		`-fsec=rint(fsec*1000) /1000;`
	`3594`	`+fsec=floor(fsec*1000) /1000;`
`3595`	`3595`	`#endif`
`3596`	`3596`	`break;`
`3597`	`3597`	`caseDTK_MICROSEC:`
`3598`	`3598`	`#ifndefHAVE_INT64_TIMESTAMP`
`3599`		`-fsec=rint(fsec*1000000) /1000000;`
	`3599`	`+fsec=floor(fsec*1000000) /1000000;`
`3600`	`3600`	`#endif`
`3601`	`3601`	`break;`
`3602`	`3602`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit47386fe

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/timestamp.c‎`

0 commit comments