NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit46bd14a

committed

Fix small query-lifespan memory leak in bulk updates.

When there is an identifiable REPLICA IDENTITY index on the target table,heap_update leaks the id_attrs bitmapset. That's not many bytes, but itadds up over enough rows, since the code typically runs in a query-lifespancontext. Bug introduced in commite55704d, which did a rather poor jobof cloning the existing use-pattern for RelationGetIndexAttrBitmap().Per bug #14293 from Zhou Digoal. Back-patch to 9.4 where the bug wasintroduced.Report: <20160824114320.15676.45171@wrigleys.postgresql.org>

1 parent25fe5f7 commit46bd14aCopy full SHA for 46bd14a

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3579,6 +3579,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`3579`	`3579`	`ReleaseBuffer(vmbuffer);`
`3580`	`3580`	`bms_free(hot_attrs);`
`3581`	`3581`	`bms_free(key_attrs);`
	`3582`	`+bms_free(id_attrs);`
`3582`	`3583`	`returnresult;`
`3583`	`3584`	`}`
`3584`	`3585`
`@@ -4031,6 +4032,7 @@ heap_update(Relation relation, ItemPointer otid, HeapTuple newtup,`
`4031`	`4032`
`4032`	`4033`	`bms_free(hot_attrs);`
`4033`	`4034`	`bms_free(key_attrs);`
	`4035`	`+bms_free(id_attrs);`
`4034`	`4036`
`4035`	`4037`	`returnHeapTupleMayBeUpdated;`
`4036`	`4038`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit46bd14a

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments