NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit45e5b4e

committed

Don't try to create a temp install without abs_top_builddir.

Otherwise, we effectively act as if abs_top_builddir were the rootdirectory, which is quite dangerous if the user happens to havepermissions to do things there. This can crop up in PGXS builds,for example.Report by Sandro Santilli, patch by me, review by Noah Misch.

1 parent883af81 commit45e5b4eCopy full SHA for 45e5b4e

File tree

1 file changed

-0

lines changed

src
- Makefile.global.in

1 file changed

-0

lines changed

`‎src/Makefile.global.in`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -320,13 +320,15 @@ check: temp-install`
`320`	`320`	`.PHONY: temp-install`
`321`	`321`	`temp-install:`
`322`	`322`	`ifndefNO_TEMP_INSTALL`
	`323`	`+ifneq ($(abs_top_builddir),)`
`323`	`324`	`ifeq ($(MAKELEVEL),0)`
`324`	`325`	`rm -rf '$(abs_top_builddir)'/tmp_install`
`325`	`326`	`$(MKDIR_P) '$(abs_top_builddir)'/tmp_install/log`
`326`	`327`	`$(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1`
`327`	`328`	`endif`
`328`	`329`	`$(if $(EXTRA_INSTALL),for extra in $(EXTRA_INSTALL); do $(MAKE) -C '$(top_builddir)'/$$extra DESTDIR='$(abs_top_builddir)'/tmp_install install >>'$(abs_top_builddir)'/tmp_install/log/install.log \|\| exit; done)`
`329`	`330`	`endif`
	`331`	`+endif`
`330`	`332`
`331`	`333`	`PROVE = @PROVE@`
`332`	`334`	`PG_PROVE_FLAGS = -I$(top_srcdir)/src/test/perl/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit45e5b4e

File tree

1 file changed

1 file changed

`‎src/Makefile.global.in`

0 commit comments