- Notifications
You must be signed in to change notification settings - Fork5
Commit440953e
committed
Tom, happier with the attached patch?
I'd have to disagree with regards to the memory leaks not being wortha mention - any such leak can cause problems when the PostgreSQLinstallation is either unattended, long-living andor has very highconnection levels. Half a kilobyte on start-up isn't negligible inthis light.Regards, Lee.Tom Lane writes: > Lee Kindness <lkindness@csl.co.uk> writes: > > Guys, attached is a patch to fix two memory leaks on start-up. > > I do not like the changes to miscinit.c. In the first place, it is not > a "memory leak" to do a one-time allocation of state for a proc_exit > function. A bigger complaint is that your proposed change introduces > fragile coupling between CreateLockFile and its callers, in order to > save no resources worth mentioning. More, it introduces an assumption > that the globals directoryLockFile and socketLockFile don't change while > the postmaster is running. UnlinkLockFile should unlink the file that > it was originally told to unlink, regardless of what happens to those > globals. > > If you are intent on spending code to free stuff just before the > postmaster exits, a better fix would be for UnlinkLockFile to free its > string argument after using it.Lee Kindness1 parent51e46d1 commit440953e
1 file changed
+10
-3
lines changedLines changed: 10 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
8 | 8 |
| |
9 | 9 |
| |
10 | 10 |
| |
11 |
| - | |
| 11 | + | |
12 | 12 |
| |
13 | 13 |
| |
14 | 14 |
| |
| |||
685 | 685 |
| |
686 | 686 |
| |
687 | 687 |
| |
688 |
| - | |
689 |
| - | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
690 | 697 |
| |
691 | 698 |
| |
692 | 699 |
| |
|
0 commit comments
Comments
(0)