NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit43fe90f

committed

Suppress -0 in the C field of lines computed by line_construct_pts().

It's not entirely clear why some PPC machines are generating -0 here, sincethe underlying computation should be exactly 0 - 0. Perhaps there's somewider-than-nominal-precision calculations happening? Anyway, the best wayto avoid platform-dependent results seems to be to explicitly reset -0 toregular zero.

1 parent1f7a479 commit43fe90fCopy full SHA for 43fe90f

File tree

1 file changed

-0

lines changed

src/backend/utils/adt
- geo_ops.c

1 file changed

-0

lines changed

`‎src/backend/utils/adt/geo_ops.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1116,6 +1116,9 @@ line_construct_pts(LINE line, Point pt1, Point *pt2)`
`1116`	`1116`	`line->A= (pt2->y-pt1->y) / (pt2->x-pt1->x);`
`1117`	`1117`	`line->B=-1.0;`
`1118`	`1118`	`line->C=pt1->y-line->A*pt1->x;`
	`1119`	`+/* on some platforms, the preceding expression tends to produce -0 */`
	`1120`	`+if (line->C==0.0)`
	`1121`	`+line->C=0.0;`
`1119`	`1122`	`#ifdefGEODEBUG`
`1120`	`1123`	`printf("line_construct_pts- line is neither vertical nor horizontal (diffs x=%.g, y=%.g\n",`
`1121`	`1124`	`DBL_DIG, (pt2->x-pt1->x),DBL_DIG, (pt2->y-pt1->y));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit43fe90f

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/geo_ops.c`

0 commit comments