NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit43ef6ab

committed

Improve unreachability recognition in elog() macro.

Some experimentation with an older version of gcc showed that it is ableto determine whether "if (elevel_ >= ERROR)" is compile-time constantif elevel_ is declared "const", but otherwise not so much. We hadaccounted for that in ereport() but were too miserly with braces tomake it so in elog(). I don't know how many currently-interestingcompilers have the same quirk, but in case it will save some codespace, let's make sure that elog() is on the same footing as ereport()for this purpose.Back-patch to 9.3 where we introduced pg_unreachable() calls intoelog/ereport.

1 parentbca6eeb commit43ef6abCopy full SHA for 43ef6ab

File tree

1 file changed

-5

lines changed

src/include/utils
- elog.h

1 file changed

-5

lines changed

`‎src/include/utils/elog.h`

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -216,12 +216,13 @@ extern intgetinternalerrposition(void);`
`216`	`216`	`#else/* !HAVE__BUILTIN_CONSTANT_P */`
`217`	`217`	`#defineelog(elevel, ...) \`
`218`	`218`	`do { \`
`219`		`-intelevel_; \`
`220`	`219`	`elog_start(__FILE__, __LINE__, PG_FUNCNAME_MACRO); \`
`221`		`-elevel_ = (elevel); \`
`222`		`-elog_finish(elevel_, __VA_ARGS__); \`
`223`		`-if (elevel_ >= ERROR) \`
`224`		`-pg_unreachable(); \`
	`220`	`+{ \`
	`221`	`+const int elevel_ = (elevel); \`
	`222`	`+elog_finish(elevel_, __VA_ARGS__); \`
	`223`	`+if (elevel_ >= ERROR) \`
	`224`	`+pg_unreachable(); \`
	`225`	`+} \`
`225`	`226`	`} while(0)`
`226`	`227`	`#endif/* HAVE__BUILTIN_CONSTANT_P */`
`227`	`228`	`#else/* !HAVE__VA_ARGS */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit43ef6ab

File tree

1 file changed

1 file changed

`‎src/include/utils/elog.h`

0 commit comments