NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3f88b08

committed

Fix some minor issues in view pretty-printing.

Code review for commit2f582f7: don't usea static variable for what ought to be a deparse_context field, fixnon-multibyte-safe test for spaces, avoid useless and potentially O(N^2)(though admittedly with a very small constant) calculations of wrappositions when we aren't going to wrap.

1 parentc2b3218 commit3f88b08Copy full SHA for 3f88b08

File tree

2 files changed

+119

-107

lines changed

doc/src/sgml
- func.sgml
src/backend/utils/adt
- ruleutils.c

2 files changed

+119

-107

lines changed

`‎doc/src/sgml/func.sgml`

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -13858,7 +13858,7 @@ SELECT pg_type_is_visible('myschema.widget'::regtype);`
`13858`	`13858`	`<row>`
`13859`	`13859`	`<entry><literal><function>pg_get_viewdef(<parameter>view_name</parameter>, <parameter>pretty_bool</>)</function></literal></entry>`
`13860`	`13860`	`<entry><type>text</type></entry>`
`13861`		`- <entry>get underlying <command>SELECT</command> command for view,`
	`13861`	`+ <entry>get underlying <command>SELECT</command> command for view;`
`13862`	`13862`	`lines with fields are wrapped to 80 columns if <parameter>pretty_bool</parameter> is true (<emphasis>deprecated</emphasis>)</entry>`
`13863`	`13863`	`</row>`
`13864`	`13864`	`<row>`
`@@ -13869,14 +13869,15 @@ SELECT pg_type_is_visible('myschema.widget'::regtype);`
`13869`	`13869`	`<row>`
`13870`	`13870`	`<entry><literal><function>pg_get_viewdef(<parameter>view_oid</parameter>, <parameter>pretty_bool</>)</function></literal></entry>`
`13871`	`13871`	`<entry><type>text</type></entry>`
`13872`		`- <entry>get underlying <command>SELECT</command> command for view,`
	`13872`	`+ <entry>get underlying <command>SELECT</command> command for view;`
`13873`	`13873`	`lines with fields are wrapped to 80 columns if <parameter>pretty_bool</parameter> is true</entry>`
`13874`	`13874`	`</row>`
`13875`	`13875`	`<row>`
`13876`		`- <entry><literal><function>pg_get_viewdef(<parameter>view_oid</parameter>, <parameter>wrap_int</>)</function></literal></entry>`
	`13876`	`+ <entry><literal><function>pg_get_viewdef(<parameter>view_oid</parameter>, <parameter>wrap_column_int</>)</function></literal></entry>`
`13877`	`13877`	`<entry><type>text</type></entry>`
`13878`		`- <entry>get underlying <command>SELECT</command> command for view,`
`13879`		`- wrapping lines with fields as specified, pretty printing is implied</entry>`
	`13878`	`+ <entry>get underlying <command>SELECT</command> command for view;`
	`13879`	`+ lines with fields are wrapped to specified number of columns,`
	`13880`	`+ pretty printing is implied</entry>`
`13880`	`13881`	`</row>`
`13881`	`13882`	`<row>`
`13882`	`13883`	`<entry><literal><function>pg_options_to_table(<parameter>reloptions</parameter>)</function></literal></entry>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3f88b08

File tree

2 files changed

2 files changed

`‎doc/src/sgml/func.sgml`

0 commit comments