- Notifications
You must be signed in to change notification settings - Fork5
Commit3d5282c
committed
Emit a log message if output is about to be redirected away from stderr.
We've seen multiple cases of people looking at the postmaster's originalstderr output to try to diagnose problems, not realizing/remembering thattheir logging configuration is set up to send log messages somewhere else.This seems particularly likely to happen in prepackaged distributions,since many packagers patch the code to change the factory-standard loggingconfiguration to something more in line with their platform conventions.In hopes of reducing confusion, emit a LOG message about this at the pointin startup where we are about to switch log output away from the originalstderr, providing a pointer to where to look instead. This message willappear as the last thing in the original stderr output. (We might lateralso try to emit such link messages when logging parameters are changedon-the-fly; but that case seems to be both noticeably harder to do nicely,and much less frequently a problem in practice.)Per discussion, back-patch to 9.3 but not further.1 parentb52cd9d commit3d5282c
File tree
5 files changed
+27
-5
lines changed- src
- backend
- postmaster
- utils
- error
- misc
- include/utils
5 files changed
+27
-5
lines changedLines changed: 10 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1164 | 1164 |
| |
1165 | 1165 |
| |
1166 | 1166 |
| |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
1167 | 1171 |
| |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
1168 | 1178 |
| |
1169 | 1179 |
| |
1170 | 1180 |
| |
|
Lines changed: 14 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
634 | 634 |
| |
635 | 635 |
| |
636 | 636 |
| |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
637 | 651 |
| |
638 | 652 |
| |
639 | 653 |
| |
| |||
649 | 663 |
| |
650 | 664 |
| |
651 | 665 |
| |
652 |
| - | |
653 |
| - | |
654 | 666 |
| |
655 | 667 |
| |
656 | 668 |
| |
|
Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
109 | 109 |
| |
110 | 110 |
| |
111 | 111 |
| |
| 112 | + | |
112 | 113 |
| |
113 | 114 |
| |
114 | 115 |
| |
|
Lines changed: 1 addition & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
444 | 444 |
| |
445 | 445 |
| |
446 | 446 |
| |
447 |
| - | |
448 |
| - | |
449 | 447 |
| |
450 | 448 |
| |
451 | 449 |
| |
| |||
2871 | 2869 |
| |
2872 | 2870 |
| |
2873 | 2871 |
| |
2874 |
| - | |
| 2872 | + | |
2875 | 2873 |
| |
2876 | 2874 |
| |
2877 | 2875 |
| |
|
Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
428 | 428 |
| |
429 | 429 |
| |
430 | 430 |
| |
| 431 | + | |
431 | 432 |
| |
432 | 433 |
| |
433 | 434 |
| |
|
0 commit comments
Comments
(0)