NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3cfb572

committed

Fix buffer pin leak in heap update redo routine.

In a heap update, if the old and new tuple were on different pages, and thenew page no longer existed (because it was subsequently truncated away byvacuum), heap_xlog_update forgot to release the pin on the old buffer. Thisbug was introduced by the "Fix multiple problems in WAL replay" patch,commit3bbf668 (on master branch).With full_page_writes=off, this triggered an "incorrect local pin count"error later in replay, if the old page was vacuumed.This fixes bug #7969, reported by Yunong Xiao. Backpatch to 9.0, like thecommit that introduced this bug.

1 parent7a5a59d commit3cfb572Copy full SHA for 3cfb572

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6824,7 +6824,11 @@ newt:;`
`6824`	`6824`	`ItemPointerGetBlockNumber(&(xlrec->newtid)),`
`6825`	`6825`	`false);`
`6826`	`6826`	`if (!BufferIsValid(nbuffer))`
	`6827`	`+{`
	`6828`	`+if (BufferIsValid(obuffer))`
	`6829`	`+UnlockReleaseBuffer(obuffer);`
`6827`	`6830`	`return;`
	`6831`	`+}`
`6828`	`6832`	`page= (Page)BufferGetPage(nbuffer);`
`6829`	`6833`
`6830`	`6834`	`if (lsn <=PageGetLSN(page))/* changes are applied */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3cfb572

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments